Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(sysadvisor): choose effective headroom and provison policy by co… #13

Merged

Conversation

waynepeking348
Copy link
Collaborator

According to the design of resource advisor, the specified policies will be performed during the updating phase of resource advisor. and we only select one effective policy to GetHeadroom and GetProvision by priority order. For now, the policied with priority should be configured by cmdline, and dynamic configuration for policy will be supported in the near future.

…nfiguration

According to the design of resource advisor, the specified policies will be performed during the updating phase of resource advisor.
and we only select one effective policy to GetHeadroom and GetProvision by priority order. For now, the policied with priority should be configured by cmdline,
and dynamic configuration for policy will be supported in the near future.

Signed-off-by: linzhecheng <linzhecheng@bytedance.com>
Signed-off-by: linzhecheng <linzhecheng@bytedance.com>
@waynepeking348 waynepeking348 added the enhancement New feature or request label Apr 11, 2023
@waynepeking348 waynepeking348 added this to the v0.1 milestone Apr 11, 2023
@codecov
Copy link

codecov bot commented Apr 11, 2023

Codecov Report

Patch coverage: 58.22% and project coverage change: +0.78 🎉

Comparison is base (96dd308) 41.98% compared to head (b94d82c) 42.76%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #13      +/-   ##
==========================================
+ Coverage   41.98%   42.76%   +0.78%     
==========================================
  Files         146      143       -3     
  Lines       23538    23374     -164     
==========================================
+ Hits         9882     9997     +115     
+ Misses      12364    12058     -306     
- Partials     1292     1319      +27     
Flag Coverage Δ
unittest 42.76% <58.22%> (+0.78%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...qrm-plugins/cpu/dynamicpolicy/cpuadvisor/cpu.pb.go 17.37% <0.00%> (ø)
pkg/agent/qrm-plugins/cpu/dynamicpolicy/policy.go 38.92% <0.00%> (-0.10%) ⬇️
.../qrm-plugins/cpu/dynamicpolicy/state/checkpoint.go 100.00% <ø> (ø)
...lugins/memory/dynamicpolicy/allocation_handlers.go 49.34% <0.00%> (ø)
...g/agent/qrm-plugins/memory/dynamicpolicy/policy.go 30.39% <0.00%> (ø)
pkg/agent/qrm-plugins/util/util.go 23.71% <ø> (ø)
...t/resourcemanager/fetcher/kubelet/kubeletplugin.go 33.33% <ø> (-33.34%) ⬇️
...t/resourcemanager/fetcher/kubelet/topology/util.go 68.33% <ø> (ø)
...nt/sysadvisor/plugin/qosaware/server/cpu/helper.go 80.35% <ø> (ø)
...metric/collector/prometheus/collector_promethes.go 0.00% <ø> (ø)
... and 29 more

... and 4 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@waynepeking348 waynepeking348 merged commit 413cc12 into kubewharf:main Apr 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants