Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

supplement metric and expand the ability to add external metric #131

Merged

Conversation

waynepeking348
Copy link
Collaborator

What type of PR is this?

enhancements

What this PR does / why we need it:

  1. add metric for rss, cache and cpu usage for cgroup v2
  2. expand the ability to add external metric

@codecov
Copy link

codecov bot commented Jul 6, 2023

Codecov Report

Patch coverage: 51.86% and project coverage change: -0.66 ⚠️

Comparison is base (21d86d9) 51.30% compared to head (c88ed79) 50.64%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #131      +/-   ##
==========================================
- Coverage   51.30%   50.64%   -0.66%     
==========================================
  Files         318      390      +72     
  Lines       32418    37180    +4762     
==========================================
+ Hits        16632    18831    +2199     
- Misses      13840    16224    +2384     
- Partials     1946     2125     +179     
Flag Coverage Δ
unittest 50.64% <51.86%> (-0.66%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
cmd/base/context_fake.go 70.28% <ø> (ø)
cmd/katalyst-agent/app/agent/eviction.go 0.00% <0.00%> (ø)
pkg/agent/evictionmanager/endpoint/endpoint.go 0.00% <ø> (ø)
pkg/agent/qrm-plugins/advisorsvc/advisor_svc.pb.go 10.43% <ø> (ø)
...ins/cpu/dynamicpolicy/calculator/cpu_assignment.go 77.01% <ø> (ø)
...gins/cpu/dynamicpolicy/cpueviction/cpu_eviciton.go 0.00% <0.00%> (-63.25%) ⬇️
pkg/agent/qrm-plugins/cpu/dynamicpolicy/policy.go 43.49% <ø> (+5.15%) ⬆️
...nt/qrm-plugins/memory/dynamicpolicy/state/state.go 63.63% <ø> (-2.31%) ⬇️
...ins/memory/dynamicpolicy/state/state_checkpoint.go 48.05% <ø> (ø)
...rm-plugins/memory/dynamicpolicy/state/state_mem.go 74.76% <ø> (+0.79%) ⬆️
... and 197 more

... and 42 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@waynepeking348 waynepeking348 force-pushed the add_malachite_metrics branch 2 times, most recently from 273f08c to 5ccfd44 Compare July 6, 2023 03:10
@waynepeking348 waynepeking348 force-pushed the add_malachite_metrics branch from 5ccfd44 to c88ed79 Compare July 6, 2023 04:36
@waynepeking348 waynepeking348 self-assigned this Jul 6, 2023
@waynepeking348 waynepeking348 added workflow/merge-ready merge-ready: code is ready and can be merged workflow/need-review review: test succeeded, need to review labels Jul 6, 2023
@waynepeking348 waynepeking348 merged commit fa3b08b into kubewharf:main Jul 6, 2023
luomingmeng pushed a commit to luomingmeng/katalyst-core that referenced this pull request Oct 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
workflow/merge-ready merge-ready: code is ready and can be merged workflow/need-review review: test succeeded, need to review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants