enhance memory plugin with advisor #136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
csfldf
requested review from
waynepeking348,
cheney-lin,
sun-yuliang and
luomingmeng
csfldf
force-pushed
the
dev/mem_plugin_with_advisor
branch
from
6b5e1aa to
0bae8a3
Compare
csfldf
force-pushed
the
dev/mem_plugin_with_advisor
branch
4 times, most recently
from
9362003 to
1dd6e40
Compare
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #136 +/- ##
==========================================
+ Coverage 50.25% 50.27% +0.01%
==========================================
Files 393 403 +10
Lines 37767 38502 +735
==========================================
+ Hits 18978 19355 +377
- Misses 16642 16978 +336
- Partials 2147 2169 +22
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
pkg/agent/qrm-plugins/memory/dynamicpolicy/policy_async_handler.go
Outdated
Show resolved
Hide resolved
pkg/agent/qrm-plugins/memory/dynamicpolicy/policy_async_handler.go
Outdated
Show resolved
Hide resolved
pkg/agent/qrm-plugins/memory/dynamicpolicy/memoryadvisor/policy_control_knob_handlers.go
Show resolved
Hide resolved
csfldf
force-pushed
the
dev/mem_plugin_with_advisor
branch
12 times, most recently
from
48990a6 to
cb13f99
Compare
csfldf
force-pushed
the
dev/mem_plugin_with_advisor
branch
from
cb13f99 to
1762111
Compare
waynepeking348
approved these changes
Jul 18, 2023
waynepeking348
added
the
workflow/merge-ready
cheney-lin
approved these changes
Jul 18, 2023
luomingmeng
pushed a commit
to luomingmeng/katalyst-core
that referenced
this pull request
Oct 11, 2024
* fix(qrm): fix cpu allocation handlers log * feat(qrm): enhance memory plugin with advisor * fix(qrm): use NUMA balance stategy for blocks with fake NUMA id * test(qrm): add unit-tests for memory plugin with advisor * fix(qrm): fix cpu/memory state struct clone semantic * refine(qrm): refine according to comments for memory plugin with advisor * fix(test): fix write/read race for testing --------- Co-authored-by: shaowei.wayne <shaowei.wayne@bytedance.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
enhance memory plugin with advisor