Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

run ut parallelly to make it fast #141

Conversation

waynepeking348
Copy link
Collaborator

What type of PR is this?

enhancements

What this PR does / why we need it:

run ut parallelly to make it fast

@waynepeking348 waynepeking348 requested review from caohe and zzzzhhb July 11, 2023 09:20
@waynepeking348 waynepeking348 force-pushed the make-ut-runner-parallel-to-make-it-fast branch 2 times, most recently from 8e026e2 to 1d392d2 Compare July 11, 2023 15:48
@codecov
Copy link

codecov bot commented Jul 11, 2023

Codecov Report

Patch coverage: 90.66% and project coverage change: -0.65 ⚠️

Comparison is base (7f8ca3b) 50.39% compared to head (02bf6c4) 49.74%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #141      +/-   ##
==========================================
- Coverage   50.39%   49.74%   -0.65%     
==========================================
  Files         393      393              
  Lines       37726    37765      +39     
==========================================
- Hits        19011    18788     -223     
- Misses      16562    16860     +298     
+ Partials     2153     2117      -36     
Flag Coverage Δ
unittest 49.74% <90.66%> (-0.65%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...kg/metaserver/agent/metric/malachite/cgroup/cri.go 0.00% <ø> (ø)
pkg/scheduler/plugins/qosawarenoderesources/fit.go 61.42% <ø> (ø)
pkg/agent/qrm-plugins/cpu/dynamicpolicy/policy.go 43.31% <25.00%> (-0.06%) ⬇️
.../agent/qrm-plugins/cpu/dynamicpolicy/state/util.go 74.72% <80.00%> (+2.43%) ⬆️
pkg/metaserver/config/checkpoint.go 92.15% <92.30%> (+3.92%) ⬆️
...lugins/cpu/dynamicpolicy/policy_advisor_handler.go 35.12% <100.00%> (ø)
...ns/cpu/dynamicpolicy/policy_allocation_handlers.go 44.67% <100.00%> (ø)
pkg/config/metric/store.go 100.00% <100.00%> (ø)
pkg/custom-metric/store/local/local_store.go 69.11% <100.00%> (ø)
pkg/metaserver/agent/metric/fake_metric.go 64.58% <100.00%> (+4.16%) ⬆️
... and 4 more

... and 18 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

zzzzhhb
zzzzhhb previously approved these changes Jul 12, 2023
@waynepeking348 waynepeking348 force-pushed the make-ut-runner-parallel-to-make-it-fast branch 15 times, most recently from 743706f to 13461fd Compare July 13, 2023 12:15
@waynepeking348 waynepeking348 added test failure workflow/draft draft: no need to review labels Jul 13, 2023
@waynepeking348 waynepeking348 force-pushed the make-ut-runner-parallel-to-make-it-fast branch 6 times, most recently from 3c7ee8b to 032025c Compare July 14, 2023 09:51
@waynepeking348 waynepeking348 force-pushed the make-ut-runner-parallel-to-make-it-fast branch 2 times, most recently from bf28c15 to 5d9bfdc Compare July 16, 2023 08:59
@waynepeking348 waynepeking348 force-pushed the make-ut-runner-parallel-to-make-it-fast branch 13 times, most recently from 4875853 to 773355e Compare July 16, 2023 15:06
@waynepeking348 waynepeking348 force-pushed the make-ut-runner-parallel-to-make-it-fast branch from 773355e to 02bf6c4 Compare July 16, 2023 15:15
@waynepeking348 waynepeking348 added workflow/merge-ready merge-ready: code is ready and can be merged workflow/need-review review: test succeeded, need to review and removed workflow/draft draft: no need to review labels Jul 17, 2023
Copy link
Member

@caohe caohe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@waynepeking348 waynepeking348 merged commit 12aef70 into kubewharf:main Jul 17, 2023
luomingmeng pushed a commit to luomingmeng/katalyst-core that referenced this pull request Oct 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
test failure workflow/merge-ready merge-ready: code is ready and can be merged workflow/need-review review: test succeeded, need to review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants