Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(*): add switches to enable only components required for topology-aware scheduling #151

Merged
merged 3 commits into from
Jul 20, 2023

Conversation

caohe
Copy link
Member

@caohe caohe commented Jul 17, 2023

What type of PR is this?

Enhancements

What this PR does / why we need it:

  • Add a switch to disable cnc lifecycle controller
  • Add a switch to disable metrics fetcher

Which issue(s) this PR fixes:

Special notes for your reviewer:

@caohe caohe added enhancement New feature or request workflow/need-review review: test succeeded, need to review labels Jul 17, 2023
@caohe caohe added this to the v0.3 milestone Jul 17, 2023
@codecov
Copy link

codecov bot commented Jul 17, 2023

Codecov Report

Patch coverage: 59.52% and project coverage change: -0.11 ⚠️

Comparison is base (8566424) 50.32% compared to head (49278b6) 50.21%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #151      +/-   ##
==========================================
- Coverage   50.32%   50.21%   -0.11%     
==========================================
  Files         407      408       +1     
  Lines       38729    38760      +31     
==========================================
- Hits        19491    19464      -27     
- Misses      17042    17117      +75     
+ Partials     2196     2179      -17     
Flag Coverage Δ
unittest 50.21% <59.52%> (-0.11%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/config/agent/global/metaserver.go 100.00% <ø> (ø)
pkg/metaserver/agent/cnc/fake_cnc.go 0.00% <0.00%> (ø)
...md/katalyst-agent/app/options/global/metaserver.go 51.38% <50.00%> (-0.18%) ⬇️
cmd/katalyst-controller/app/options/lifecycle.go 47.36% <60.00%> (+0.11%) ⬆️
pkg/metaserver/agent/agent.go 76.38% <70.83%> (-6.37%) ⬇️
pkg/config/controller/lifecycle.go 100.00% <100.00%> (ø)

... and 16 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

caohe added 2 commits July 20, 2023 11:15
Signed-off-by: caohe <caohe9603@gmail.com>
Signed-off-by: caohe <caohe9603@gmail.com>
…y are not enabled

Signed-off-by: caohe <caohe9603@gmail.com>
@waynepeking348 waynepeking348 merged commit 2cc0d49 into kubewharf:main Jul 20, 2023
@caohe caohe deleted the add-switches branch July 20, 2023 06:01
luomingmeng pushed a commit to luomingmeng/katalyst-core that referenced this pull request Oct 11, 2024
…-aware scheduling (kubewharf#151)

* feat(lifecycle): add a switch to disable cnc lifecycle controller

Signed-off-by: caohe <caohe9603@gmail.com>

* feat(metaserver): add a switch to disable metrics fetcher

Signed-off-by: caohe <caohe9603@gmail.com>

* refactor(metaserver): use fake metrics fetcher and cnc fetcher if they are not enabled

Signed-off-by: caohe <caohe9603@gmail.com>

---------

Signed-off-by: caohe <caohe9603@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request workflow/need-review review: test succeeded, need to review
Projects
Status: 👀 In review
Development

Successfully merging this pull request may close these issues.

3 participants