Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move malachite client from global varibales to malachite fetcher #152

Conversation

waynepeking348
Copy link
Collaborator

What type of PR is this?

bug fixes/Enhancements

What this PR does / why we need it:

move malachite client from global variables to malachite fetcher to avoid testing races

@waynepeking348 waynepeking348 added bug Something isn't working workflow/need-review review: test succeeded, need to review workflow/merge-ready merge-ready: code is ready and can be merged labels Jul 17, 2023
@waynepeking348 waynepeking348 force-pushed the make-ut-runner-parallel-to-make-it-fast branch from 7bf996d to 7451b4d Compare July 17, 2023 11:23
@codecov
Copy link

codecov bot commented Jul 17, 2023

Codecov Report

Patch coverage: 85.56% and project coverage change: -0.28 ⚠️

Comparison is base (3ecec50) 50.48% compared to head (7451b4d) 50.20%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #152      +/-   ##
==========================================
- Coverage   50.48%   50.20%   -0.28%     
==========================================
  Files         393      393              
  Lines       37728    37767      +39     
==========================================
- Hits        19048    18962      -86     
- Misses      16538    16678     +140     
+ Partials     2142     2127      -15     
Flag Coverage Δ
unittest 50.20% <85.56%> (-0.28%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...kg/metaserver/agent/metric/malachite/cgroup/cri.go 0.00% <ø> (ø)
pkg/scheduler/plugins/qosawarenoderesources/fit.go 61.42% <ø> (ø)
pkg/agent/qrm-plugins/cpu/dynamicpolicy/policy.go 43.31% <25.00%> (-0.06%) ⬇️
...metaserver/agent/metric/malachite/cgroup/cgroup.go 53.03% <50.00%> (ø)
pkg/metaserver/agent/metric/metric.go 53.74% <54.54%> (+0.06%) ⬆️
.../agent/qrm-plugins/cpu/dynamicpolicy/state/util.go 74.72% <80.00%> (+2.43%) ⬆️
pkg/metaserver/config/checkpoint.go 92.15% <92.30%> (+3.92%) ⬆️
...lugins/cpu/dynamicpolicy/policy_advisor_handler.go 35.12% <100.00%> (ø)
...ns/cpu/dynamicpolicy/policy_allocation_handlers.go 44.67% <100.00%> (ø)
pkg/config/metric/store.go 100.00% <100.00%> (ø)
... and 6 more

... and 10 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@waynepeking348 waynepeking348 requested a review from zzzzhhb July 17, 2023 11:35
@waynepeking348 waynepeking348 merged commit cc7f7d3 into kubewharf:main Jul 17, 2023
luomingmeng pushed a commit to luomingmeng/katalyst-core that referenced this pull request Oct 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working workflow/merge-ready merge-ready: code is ready and can be merged workflow/need-review review: test succeeded, need to review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants