Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(util): add periodical handlers util #153

Merged
merged 3 commits into from
Jul 19, 2023

Conversation

csfldf
Copy link
Collaborator

@csfldf csfldf commented Jul 18, 2023

feat(util): add periodical handlers util

@csfldf csfldf added the workflow/need-review review: test succeeded, need to review label Jul 18, 2023
@csfldf csfldf self-assigned this Jul 18, 2023
@csfldf csfldf force-pushed the dev/periodical_handler branch 2 times, most recently from f022200 to c634978 Compare July 18, 2023 07:01
@csfldf csfldf force-pushed the dev/periodical_handler branch from c634978 to 7c93650 Compare July 18, 2023 13:06
@csfldf csfldf force-pushed the dev/periodical_handler branch from 7c93650 to b91206a Compare July 18, 2023 13:18
@waynepeking348 waynepeking348 force-pushed the dev/periodical_handler branch from 9e55b1d to 7ba39cc Compare July 18, 2023 16:20
@codecov
Copy link

codecov bot commented Jul 18, 2023

Codecov Report

Patch coverage: 59.48% and project coverage change: +0.17 🎉

Comparison is base (20bae0a) 50.25% compared to head (ac94763) 50.42%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #153      +/-   ##
==========================================
+ Coverage   50.25%   50.42%   +0.17%     
==========================================
  Files         393      407      +14     
  Lines       37767    38729     +962     
==========================================
+ Hits        18978    19531     +553     
- Misses      16642    17008     +366     
- Partials     2147     2190      +43     
Flag Coverage Δ
unittest 50.42% <59.48%> (+0.17%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
cmd/katalyst-agent/app/agent/qrm/cpu_plugin.go 0.00% <ø> (ø)
...md/katalyst-agent/app/options/global/qrmadvisor.go 64.70% <ø> (ø)
...sysadvisor/metric-emitter/metric_emitter_plugin.go 43.10% <0.00%> (-8.98%) ⬇️
pkg/agent/qrm-plugins/commonstate/utils.go 0.00% <0.00%> (ø)
...-plugins/cpu/dynamicpolicy/policy_async_handler.go 15.82% <0.00%> (ø)
pkg/config/agent/global/qrmadvisor.go 100.00% <ø> (ø)
pkg/config/agent/qrm/cpu_plugin.go 100.00% <ø> (ø)
pkg/config/agent/qrm/memory_plugin.go 100.00% <ø> (ø)
pkg/util/cgroup/manager/manager.go 62.50% <ø> (ø)
pkg/util/cgroup/manager/v1/fs_linux.go 34.59% <0.00%> (+0.10%) ⬆️
... and 32 more

... and 31 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

waynepeking348
waynepeking348 previously approved these changes Jul 19, 2023
@waynepeking348 waynepeking348 force-pushed the dev/periodical_handler branch from 7ba39cc to ac94763 Compare July 19, 2023 02:45
@csfldf csfldf requested a review from waynepeking348 July 19, 2023 02:50
@csfldf csfldf added the workflow/merge-ready merge-ready: code is ready and can be merged label Jul 19, 2023
@waynepeking348 waynepeking348 merged commit 5b0b8c9 into kubewharf:main Jul 19, 2023
luomingmeng pushed a commit to luomingmeng/katalyst-core that referenced this pull request Oct 11, 2024
* feat(util): add periodical handlers util

* fix(qrm): fix cpu plugin transitionPeriod initial value

* refine the implementation for periodical handler

---------

Co-authored-by: shaowei.wayne <shaowei.wayne@bytedance.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
workflow/merge-ready merge-ready: code is ready and can be merged workflow/need-review review: test succeeded, need to review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants