Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support to define kcmas metric dynamically #155

Merged

Conversation

waynepeking348
Copy link
Collaborator

What type of PR is this?

enhancements

What this PR does / why we need it:

add cpu-usage in default metric and make it dynamic to add new metric names

@waynepeking348 waynepeking348 added enhancement New feature or request workflow/need-review review: test succeeded, need to review workflow/merge-ready merge-ready: code is ready and can be merged labels Jul 18, 2023
@waynepeking348 waynepeking348 self-assigned this Jul 18, 2023
@codecov
Copy link

codecov bot commented Jul 18, 2023

Codecov Report

Patch coverage: 78.12% and project coverage change: +0.35 🎉

Comparison is base (20bae0a) 50.25% compared to head (9906244) 50.60%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #155      +/-   ##
==========================================
+ Coverage   50.25%   50.60%   +0.35%     
==========================================
  Files         393      399       +6     
  Lines       37767    38015     +248     
==========================================
+ Hits        18978    19236     +258     
+ Misses      16642    16623      -19     
- Partials     2147     2156       +9     
Flag Coverage Δ
unittest 50.60% <78.12%> (+0.35%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...sysadvisor/metric-emitter/metric_emitter_plugin.go 43.10% <0.00%> (-8.98%) ⬇️
pkg/metaserver/agent/metric/helper/pod.go 68.42% <68.42%> (ø)
...in/qosaware/resource/memory/plugin/memory_guard.go 69.38% <69.38%> (ø)
...advisor/plugin/qosaware/resource/memory/advisor.go 78.91% <70.90%> (+5.70%) ⬆️
pkg/metaserver/agent/metric/helper/system.go 72.30% <72.30%> (ø)
pkg/metaserver/agent/metric/helper/container.go 73.33% <73.33%> (ø)
...sadvisor/plugin/metric-emitter/syncer/node/node.go 42.16% <83.33%> (+2.92%) ⬆️
...sysadvisor/plugin/metric-emitter/syncer/pod/pod.go 66.44% <83.33%> (+0.90%) ⬆️
...in/qosaware/resource/memory/plugin/cache_reaper.go 91.30% <91.30%> (ø)
...n/qosaware/resource/memory/plugin/memset_binder.go 92.50% <92.50%> (ø)
... and 7 more

... and 10 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@waynepeking348 waynepeking348 force-pushed the dev/add-metrics-for-kcmas branch from c4f0861 to 21b3ad9 Compare July 18, 2023 09:17
@waynepeking348 waynepeking348 force-pushed the dev/add-metrics-for-kcmas branch from 21b3ad9 to 9906244 Compare July 18, 2023 09:48
@waynepeking348 waynepeking348 merged commit ad3aff5 into kubewharf:main Jul 18, 2023
luomingmeng pushed a commit to luomingmeng/katalyst-core that referenced this pull request Oct 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request workflow/merge-ready merge-ready: code is ready and can be merged workflow/need-review review: test succeeded, need to review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants