Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sysadvisor): Pod CPU request should only be used as estimated val… #156

Merged
merged 1 commit into from
Jul 19, 2023

Conversation

cheney-lin
Copy link
Member

…ue when all metrics are missed

In the cgroupv2 scenario, the pod metrics for containers cannot be obtained, but we can still estimate CPU provison by usage.

What type of PR is this?

Bug fixes

What this PR does / why we need it:

Which issue(s) this PR fixes:

Special notes for your reviewer:

…ue when all metrics are missed

In the cgroupv2 scenario, the pod metrics for containers cannot be obtained, but we can still
estimate CPU provison by usage.

Signed-off-by: linzhecheng <linzhecheng@bytedance.com>
@cheney-lin cheney-lin added bug Something isn't working workflow/need-review review: test succeeded, need to review labels Jul 19, 2023
@cheney-lin cheney-lin added workflow/merge-ready merge-ready: code is ready and can be merged and removed workflow/need-review review: test succeeded, need to review labels Jul 19, 2023
@waynepeking348 waynepeking348 merged commit c21817d into kubewharf:main Jul 19, 2023
luomingmeng pushed a commit to luomingmeng/katalyst-core that referenced this pull request Oct 11, 2024
…ue when all metrics are missed (kubewharf#156)

In the cgroupv2 scenario, the pod metrics for containers cannot be obtained, but we can still
estimate CPU provison by usage.

Signed-off-by: linzhecheng <linzhecheng@bytedance.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working workflow/merge-ready merge-ready: code is ready and can be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants