fix(sysadvisor): set numa capicity as requirement of numabinding pods when reclaimed disabled #158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cheney-lin
force-pushed
the
dev/requirement-setting
branch
from
c1b3ea4 to
6a11f3a
Compare
cheney-lin
changed the title
cheney-lin
force-pushed
the
dev/requirement-setting
branch
from
6a11f3a to
e910da6
Compare
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #158 +/- ##
==========================================
+ Coverage 50.20% 50.67% +0.46%
==========================================
Files 408 408
Lines 38774 38833 +59
==========================================
+ Hits 19467 19677 +210
+ Misses 17126 16963 -163
- Partials 2181 2193 +12
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
cheney-lin
force-pushed
the
dev/requirement-setting
branch
2 times, most recently
from
2563ab7 to
a4cdf16
Compare
cheney-lin
added
bug
cheney-lin
force-pushed
the
dev/requirement-setting
branch
2 times, most recently
from
433c81b to
f8813fa
Compare
sun-yuliang
previously approved these changes
Jul 24, 2023
| @@ -55,6 +55,14 @@ func (p *PolicyCanonical) Update() error { | |||
| return err | |||
| } | |||
|
|
|||
| if p.regionType == types.QoSRegionTypeDedicatedNumaExclusive && !enableReclaim { | |||
There was a problem hiding this comment.
should this be moved out of range loop for for podUID, containerSet := range p.podSet {? since you will add up multiple times for cpuEstimation and containerCnt this way
There was a problem hiding this comment.
and the same for provision_canonical.go
… when reclaimed disabled Signed-off-by: linzhecheng <linzhecheng@bytedance.com>
cheney-lin
force-pushed
the
dev/requirement-setting
branch
from
f8813fa to
a099272
Compare
csfldf
approved these changes
Jul 25, 2023
waynepeking348
approved these changes
Jul 25, 2023
cheney-lin
added
workflow/merge-ready
sun-yuliang
approved these changes
Jul 25, 2023
luomingmeng
pushed a commit
to luomingmeng/katalyst-core
that referenced
this pull request
Oct 11, 2024
… when reclaimed disabled (kubewharf#158) Signed-off-by: linzhecheng <linzhecheng@bytedance.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… when reclaimed disabled
What type of PR is this?
Bug fixes
What this PR does / why we need it:
Which issue(s) this PR fixes:
Special notes for your reviewer: