Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support to register external object fecthers in metaserver #163

Conversation

waynepeking348
Copy link
Collaborator

What type of PR is this?

enhancements

What this PR does / why we need it:

support to register external object fecthers in metaserver

@waynepeking348 waynepeking348 added enhancement New feature or request workflow/need-review review: test succeeded, need to review workflow/merge-ready merge-ready: code is ready and can be merged labels Jul 23, 2023
@codecov
Copy link

codecov bot commented Jul 23, 2023

Codecov Report

Patch coverage: 85.71% and project coverage change: +0.11 🎉

Comparison is base (2cc0d49) 50.14% compared to head (77d5069) 50.26%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #163      +/-   ##
==========================================
+ Coverage   50.14%   50.26%   +0.11%     
==========================================
  Files         408      408              
  Lines       38760    38772      +12     
==========================================
+ Hits        19438    19489      +51     
+ Misses      17139    17098      -41     
- Partials     2183     2185       +2     
Flag Coverage Δ
unittest 50.26% <85.71%> (+0.11%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/metaserver/agent/agent.go 75.00% <85.71%> (-1.39%) ⬇️

... and 10 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@waynepeking348 waynepeking348 merged commit c4389f8 into kubewharf:main Jul 23, 2023
luomingmeng pushed a commit to luomingmeng/katalyst-core that referenced this pull request Oct 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request workflow/merge-ready merge-ready: code is ready and can be merged workflow/need-review review: test succeeded, need to review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants