Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: introduce percentile aggregator for window sliding #164

Merged
merged 1 commit into from
Jul 25, 2023

Conversation

cheney-lin
Copy link
Member

What type of PR is this?

Features

What this PR does / why we need it:

Which issue(s) this PR fixes:

Special notes for your reviewer:

@cheney-lin cheney-lin force-pushed the dev/percentile_window branch 2 times, most recently from e9a7a06 to ebe08b0 Compare July 24, 2023 07:37
@codecov
Copy link

codecov bot commented Jul 24, 2023

Codecov Report

Patch coverage: 79.45% and project coverage change: +0.62% 🎉

Comparison is base (c8b2187) 50.20% compared to head (29e3959) 50.82%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #164      +/-   ##
==========================================
+ Coverage   50.20%   50.82%   +0.62%     
==========================================
  Files         408      408              
  Lines       38774    38844      +70     
==========================================
+ Hits        19467    19744     +277     
+ Misses      17126    16882     -244     
- Partials     2181     2218      +37     
Flag Coverage Δ
unittest 50.82% <79.45%> (+0.62%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
.../sysadvisor/qosaware/reporter/headroom_reporter.go 100.00% <ø> (ø)
.../sysadvisor/qosaware/reporter/headroom_reporter.go 67.27% <55.55%> (-3.57%) ⬇️
pkg/util/general/window.go 89.31% <80.70%> (-6.64%) ⬇️
...r/plugin/qosaware/reporter/manager/resource/cpu.go 100.00% <100.00%> (ø)
...ugin/qosaware/reporter/manager/resource/generic.go 100.00% <100.00%> (ø)
...lugin/qosaware/reporter/manager/resource/memory.go 100.00% <100.00%> (ø)

... and 22 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cheney-lin cheney-lin added enhancement New feature or request workflow/need-review review: test succeeded, need to review labels Jul 24, 2023
@cheney-lin cheney-lin force-pushed the dev/percentile_window branch from ebe08b0 to e1955da Compare July 25, 2023 06:49
Signed-off-by: linzhecheng <linzhecheng@bytedance.com>
@cheney-lin cheney-lin force-pushed the dev/percentile_window branch from e1955da to 29e3959 Compare July 25, 2023 06:51
@cheney-lin cheney-lin requested a review from sun-yuliang July 25, 2023 06:54
@cheney-lin cheney-lin added workflow/merge-ready merge-ready: code is ready and can be merged and removed workflow/need-review review: test succeeded, need to review labels Jul 25, 2023
@waynepeking348 waynepeking348 merged commit 7f0aea5 into kubewharf:main Jul 25, 2023
luomingmeng pushed a commit to luomingmeng/katalyst-core that referenced this pull request Oct 11, 2024
Signed-off-by: linzhecheng <linzhecheng@bytedance.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request workflow/merge-ready merge-ready: code is ready and can be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants