Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor sysadvisor cpu headroom assembler by abstract the logic of util-based capacity estimation #165

Conversation

luomingmeng
Copy link
Collaborator

What type of PR is this?

Enhancements

What this PR does / why we need it:

refactor sysadvisor cpu headroom assembler by abstract the logic of util-based capacity estimation

@luomingmeng luomingmeng added chore workflow/need-review review: test succeeded, need to review labels Jul 24, 2023
@luomingmeng luomingmeng added this to the v0.2 milestone Jul 24, 2023
@luomingmeng luomingmeng self-assigned this Jul 24, 2023
@codecov
Copy link

codecov bot commented Jul 24, 2023

Codecov Report

Patch coverage: 86.84% and project coverage change: +0.50 🎉

Comparison is base (c4389f8) 50.26% compared to head (cda2d86) 50.77%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #165      +/-   ##
==========================================
+ Coverage   50.26%   50.77%   +0.50%     
==========================================
  Files         408      408              
  Lines       38772    38779       +7     
==========================================
+ Hits        19490    19691     +201     
+ Misses      17093    16870     -223     
- Partials     2189     2218      +29     
Flag Coverage Δ
unittest 50.77% <86.84%> (+0.50%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...sembler/headroomassembler/assembler_common_util.go 58.82% <68.75%> (-20.77%) ⬇️
...n/qosaware/resource/helper/estimation_canonical.go 76.63% <100.00%> (+6.04%) ⬆️

... and 16 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@luomingmeng luomingmeng marked this pull request as ready for review July 24, 2023 13:48
@waynepeking348 waynepeking348 merged commit 3ad014d into kubewharf:main Jul 25, 2023
luomingmeng added a commit to luomingmeng/katalyst-core that referenced this pull request Oct 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore workflow/need-review review: test succeeded, need to review
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

3 participants