Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add flags to enable alert logging level #167

Merged

Conversation

waynepeking348
Copy link
Collaborator

What type of PR is this?

enhancements

What this PR does / why we need it:

provide the ability to set default logging package level

@waynepeking348 waynepeking348 added enhancement New feature or request workflow/need-review review: test succeeded, need to review workflow/merge-ready merge-ready: code is ready and can be merged labels Jul 25, 2023
@waynepeking348 waynepeking348 self-assigned this Jul 25, 2023
@codecov
Copy link

codecov bot commented Jul 25, 2023

Codecov Report

Patch coverage: 75.97% and project coverage change: +0.48% 🎉

Comparison is base (20bae0a) 50.25% compared to head (fb7327c) 50.73%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #167      +/-   ##
==========================================
+ Coverage   50.25%   50.73%   +0.48%     
==========================================
  Files         393      409      +16     
  Lines       37767    38801    +1034     
==========================================
+ Hits        18978    19684     +706     
- Misses      16642    16902     +260     
- Partials     2147     2215      +68     
Flag Coverage Δ
unittest 50.73% <75.97%> (+0.48%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
pkg/util/machine/util.go 68.65% <25.00%> (+3.65%) ⬆️
pkg/util/general/log.go 58.88% <31.25%> (-6.45%) ⬇️
cmd/base/options/generic.go 47.54% <66.66%> (+0.98%) ⬆️
pkg/metaserver/agent/metric/helper/pod.go 68.42% <68.42%> (ø)
...in/qosaware/resource/memory/plugin/memory_guard.go 69.38% <69.38%> (ø)
...advisor/plugin/qosaware/resource/memory/advisor.go 78.91% <70.90%> (+5.70%) ⬆️
pkg/metaserver/agent/metric/helper/system.go 72.30% <72.30%> (ø)
pkg/metaserver/agent/metric/helper/container.go 73.33% <73.33%> (ø)
cmd/base/options/log.go 77.77% <77.77%> (ø)
...in/qosaware/resource/memory/plugin/cache_reaper.go 91.30% <91.30%> (ø)
... and 7 more

... and 63 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@waynepeking348 waynepeking348 force-pushed the support-to-config-log-level branch from fef948b to 26dbaab Compare July 25, 2023 06:22
@waynepeking348 waynepeking348 force-pushed the support-to-config-log-level branch from 26dbaab to fb7327c Compare July 25, 2023 06:34
@waynepeking348 waynepeking348 merged commit dfad0ba into kubewharf:main Jul 25, 2023
luomingmeng pushed a commit to luomingmeng/katalyst-core that referenced this pull request Oct 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request workflow/merge-ready merge-ready: code is ready and can be merged workflow/need-review review: test succeeded, need to review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants