fix(controller): fix bug if cnr or cnc is not found in lister #168
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #168 +/- ##
==========================================
- Coverage 50.94% 50.87% -0.08%
==========================================
Files 409 409
Lines 38930 38946 +16
==========================================
- Hits 19834 19814 -20
- Misses 16877 16926 +49
+ Partials 2219 2206 -13
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
caohe
added
the
workflow/merge-ready
luomingmeng
previously approved these changes
Jul 25, 2023
caohe
force-pushed
the
fix-controller-label-selector
branch
from
09e55d5 to
4aadc46
Compare
caohe
force-pushed
the
fix-controller-label-selector
branch
from
4aadc46 to
1253f13
Compare
Signed-off-by: caohe <caohe9603@gmail.com>
luomingmeng
reviewed
Jul 26, 2023
| @@ -308,6 +311,12 @@ func (cl *CNRLifecycle) updateOrCreateCNR(node *corev1.Node) error { | |||
| if err != nil && !errors.IsAlreadyExists(err) { | |||
| return fmt.Errorf("failed to create cnr %s: %v", cnr.Name, err) | |||
| } | |||
| if errors.IsAlreadyExists(err) { | |||
| cnr, err = cl.client.InternalClient.NodeV1alpha1().CustomNodeResources().Get(cl.ctx, node.Name, metav1.GetOptions{ResourceVersion: "0"}) | |||
There was a problem hiding this comment.
Should it also fix updateOrCreateCNC of cnc lifecycle like this?
There was a problem hiding this comment.
Yes, cnc will be fixed in a later pr.
waynepeking348
approved these changes
Jul 26, 2023
luomingmeng
approved these changes
Jul 26, 2023
luomingmeng
pushed a commit
to luomingmeng/katalyst-core
that referenced
this pull request
Oct 11, 2024
Signed-off-by: caohe <caohe9603@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Bug fixes
What this PR does / why we need it:
Fix bug if cnr or cnc is not found in lister.
Which issue(s) this PR fixes:
Special notes for your reviewer: