add more metrics in kcmas #169
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
waynepeking348
force-pushed
the
refine-malachite-and-fix-bugs
branch
from
5b6b801 to
edc107b
Compare
waynepeking348
added
workflow/merge-hold
waynepeking348
force-pushed
the
refine-malachite-and-fix-bugs
branch
from
edc107b to
0dd334d
Compare
dianjunsun
reviewed
Jul 27, 2023
| } | ||
|
|
||
| for pool, pods := range pool2Pods { | ||
| v := n.metaServer.AggregatePodMetric(pods, pkgconsts.MetricCPUUsage, metric.AggregatorAvg, metric.DefaultContainerMetricFilter) |
There was a problem hiding this comment.
typo? should be metric.AggregatorSum?
And cpu.load is different from cpu.usage
There was a problem hiding this comment.
typo? should be metric.AggregatorSum? And cpu.load is different from cpu.usage
yeah, this pr is still in holding state, I will testing this before change it as need-label
waynepeking348
force-pushed
the
refine-malachite-and-fix-bugs
branch
3 times, most recently
from
1ed02a0 to
f33ebd0
Compare
waynepeking348
force-pushed
the
refine-malachite-and-fix-bugs
branch
from
f33ebd0 to
9d3580c
Compare
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #169 +/- ##
=========================================
+ Coverage 0 51.29% +51.29%
=========================================
Files 0 420 +420
Lines 0 40509 +40509
=========================================
+ Hits 0 20779 +20779
- Misses 0 17456 +17456
- Partials 0 2274 +2274
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
waynepeking348
added
workflow/merge-ready
waynepeking348
force-pushed
the
refine-malachite-and-fix-bugs
branch
from
7fc1ddb to
c351ba3
Compare
csfldf
approved these changes
Jul 31, 2023
luomingmeng
approved these changes
Jul 31, 2023
luomingmeng
pushed a commit
to luomingmeng/katalyst-core
that referenced
this pull request
Oct 11, 2024
* add more metric for kcmas and refine implementation for malachite fetcher * add locks for registerred metric fetcher
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
enhancements
What this PR does / why we need it:
add more metrics in kcmas