Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support admin qos configuration for kcc #17

Merged

Conversation

waynepeking348
Copy link
Collaborator

  1. refine kcc framework to dynamically apply admin qos

@waynepeking348 waynepeking348 added the enhancement New feature or request label Apr 14, 2023
@waynepeking348 waynepeking348 added this to the v0.1 milestone Apr 14, 2023
@CLAassistant
Copy link

CLAassistant commented Apr 14, 2023

CLA assistant check
All committers have signed the CLA.

@codecov
Copy link

codecov bot commented Apr 14, 2023

Codecov Report

Patch coverage: 90.09% and project coverage change: +7.84 🎉

Comparison is base (b94d82c) 42.76% compared to head (4997a2e) 50.61%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #17      +/-   ##
==========================================
+ Coverage   42.76%   50.61%   +7.84%     
==========================================
  Files         143      312     +169     
  Lines       23374    31784    +8410     
==========================================
+ Hits         9997    16086    +6089     
- Misses      12058    13785    +1727     
- Partials     1319     1913     +594     
Flag Coverage Δ
unittest 50.61% <90.09%> (+7.84%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
cmd/katalyst-agent/app/agent/eviction.go 0.00% <0.00%> (ø)
pkg/agent/evictionmanager/manager.go 0.00% <ø> (ø)
...dvisor/plugin/qosaware/reporter/manager/manager.go 100.00% <ø> (ø)
pkg/agent/qrm-plugins/cpu/dynamicpolicy/policy.go 38.84% <33.33%> (-0.08%) ⬇️
pkg/agent/sysadvisor/plugin/qosaware/qos_aware.go 74.46% <40.00%> (ø)
...agent/app/options/global/adminqos/adminqos_base.go 54.54% <54.54%> (ø)
...gent/evictionmanager/plugin/reclaimed_resources.go 81.81% <62.50%> (-7.47%) ⬇️
pkg/metaserver/config/manager.go 63.27% <75.00%> (-3.39%) ⬇️
.../config/agent/global/adminqos/reclaimedresource.go 78.66% <78.66%> (ø)
...kg/agent/evictionmanager/plugin/memory_pressure.go 74.48% <90.90%> (-1.65%) ⬇️
... and 36 more

... and 193 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@luomingmeng luomingmeng force-pushed the support_kcc_for_admin_qos branch from aa799ee to e3f3958 Compare April 17, 2023 02:49
@luomingmeng luomingmeng force-pushed the support_kcc_for_admin_qos branch from 4c27c6b to 4997a2e Compare April 17, 2023 12:03
@waynepeking348 waynepeking348 merged commit a0fefec into kubewharf:main Apr 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants