fix(qrm): cpu plugin allocate for blocks according to calculated sequence #171
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
csfldf
added
bug
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #171 +/- ##
==========================================
- Coverage 50.97% 50.92% -0.06%
==========================================
Files 418 418
Lines 40409 40478 +69
==========================================
+ Hits 20600 20614 +14
- Misses 17539 17605 +66
+ Partials 2270 2259 -11
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
| } | ||
| return cpusets | ||
| } | ||
|
|
||
| // GetBlocks parses ListAndWatchResponse and returns map[int]map[string]*Block, |
There was a problem hiding this comment.
comment should also be modified
| entryName, subEntryName := namesTuple[0], namesTuple[1] | ||
|
|
||
| if isPod { | ||
| if subEntryName != "" { |
There was a problem hiding this comment.
- use
FakedContainerNameinstead of"" - can this sorting logic be extracted to a separate function? (since both the four-layer loops and sorting logic are a little complicated)
| // GetBlocks parses ListAndWatchResponse and returns map[int]map[string]*Block, | ||
| // the map is keyed as numa id -> block id -> block | ||
| func (lwr *ListAndWatchResponse) GetBlocks() (map[int]map[string]*Block, error) { | ||
| func (lwr *ListAndWatchResponse) GetBlocks() (map[int]map[string]*Block, map[int][]string, error) { |
There was a problem hiding this comment.
why should still keep the previous returned value (i.e. map[int]map[string]*Block) here? just for legacy reasons or for coding convenience ?
csfldf
force-pushed
the
dev/cpu_block_alloc_seq
branch
2 times, most recently
from
f9dafc8 to
6b9a058
Compare
csfldf
force-pushed
the
dev/cpu_block_alloc_seq
branch
from
6b9a058 to
aaecd01
Compare
waynepeking348
previously approved these changes
Jul 27, 2023
luomingmeng
previously approved these changes
Jul 27, 2023
csfldf
added
workflow/merge-ready
waynepeking348
dismissed stale reviews from luomingmeng and themself
via
652fd4c
luomingmeng
approved these changes
Jul 27, 2023
waynepeking348
approved these changes
Jul 27, 2023
luomingmeng
pushed a commit
to luomingmeng/katalyst-core
that referenced
this pull request
Oct 11, 2024
…ence (kubewharf#171) * fix(qrm): cpu plugin allocate for blocks according to calculated sequence * fix(qrm): refine block sequence calculation by review comments * fix concurrent testing issues for logging --------- Co-authored-by: shaowei.wayne <shaowei.wayne@bytedance.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix(qrm): cpu plugin allocate for blocks according to calculated sequence