Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: headroom policy for dedicated numa #172

Merged

Conversation

cheney-lin
Copy link
Member

What type of PR is this?

Enhancements

What this PR does / why we need it:

Which issue(s) this PR fixes:

Special notes for your reviewer:

@cheney-lin cheney-lin force-pushed the dev/headroom_ppolicy_dedicated branch from c98751e to edba866 Compare July 27, 2023 07:07
@codecov
Copy link

codecov bot commented Jul 27, 2023

Codecov Report

Patch coverage: 67.54% and project coverage change: +50.83% 🎉

Comparison is base (4e5a93d) 0.00% compared to head (b3a4081) 50.83%.

Additional details and impacted files
@@            Coverage Diff            @@
##           main     #172       +/-   ##
=========================================
+ Coverage      0   50.83%   +50.83%     
=========================================
  Files         0      419      +419     
  Lines         0    40577    +40577     
=========================================
+ Hits          0    20627    +20627     
- Misses        0    17690    +17690     
- Partials      0     2260     +2260     
Flag Coverage Δ
unittest 50.83% <67.54%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
...urce/cpu/region/headroompolicy/policy_canonical.go 78.04% <33.33%> (ø)
...sadvisor/plugin/qosaware/resource/helper/helper.go 37.03% <33.33%> (ø)
pkg/util/general/common.go 72.32% <66.66%> (ø)
...cpu/region/headroompolicy/policy_numa_exclusive.go 70.31% <70.31%> (ø)
pkg/metaserver/spd/manager.go 55.22% <73.33%> (ø)
...sysadvisor/plugin/qosaware/resource/cpu/advisor.go 70.85% <100.00%> (ø)
...resource/memory/headroompolicy/policy_canonical.go 73.03% <100.00%> (ø)
pkg/agent/sysadvisor/types/helper.go 68.44% <100.00%> (ø)

... and 411 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cheney-lin cheney-lin force-pushed the dev/headroom_ppolicy_dedicated branch 7 times, most recently from 4a799cf to eaef868 Compare July 28, 2023 06:38
@cheney-lin cheney-lin changed the title feat: headroom policy of dedicated numa feat: headroom policy for dedicated numa Jul 28, 2023
@cheney-lin cheney-lin added enhancement New feature or request workflow/need-review review: test succeeded, need to review labels Jul 28, 2023
Service performance score is considerd in new policy.

Signed-off-by: linzhecheng <linzhecheng@bytedance.com>
@cheney-lin cheney-lin force-pushed the dev/headroom_ppolicy_dedicated branch from eaef868 to b3a4081 Compare July 31, 2023 05:00
@cheney-lin cheney-lin added workflow/merge-ready merge-ready: code is ready and can be merged and removed workflow/need-review review: test succeeded, need to review labels Jul 31, 2023
@waynepeking348 waynepeking348 merged commit f9e16b5 into kubewharf:main Jul 31, 2023
luomingmeng pushed a commit to luomingmeng/katalyst-core that referenced this pull request Oct 11, 2024
Service performance score is considerd in new policy.

Signed-off-by: linzhecheng <linzhecheng@bytedance.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request workflow/merge-ready merge-ready: code is ready and can be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants