Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

zoneNode remove id field and use resource identifier to make sure it uniq #174

Conversation

luomingmeng
Copy link
Collaborator

What type of PR is this?

Enhancements

What this PR does / why we need it:

zoneNode remove id field and use resource identifier to make sure it uniq instead

Which issue(s) this PR fixes:

Special notes for your reviewer:

@luomingmeng luomingmeng added chore workflow/need-review review: test succeeded, need to review labels Jul 27, 2023
@luomingmeng luomingmeng added this to the v0.3 milestone Jul 27, 2023
@luomingmeng luomingmeng self-assigned this Jul 27, 2023
@luomingmeng luomingmeng marked this pull request as ready for review July 27, 2023 09:58
@codecov
Copy link

codecov bot commented Jul 27, 2023

Codecov Report

Patch coverage: 57.14% and project coverage change: +0.21% 🎉

Comparison is base (085b466) 50.83% compared to head (f6a091a) 51.04%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #174      +/-   ##
==========================================
+ Coverage   50.83%   51.04%   +0.21%     
==========================================
  Files         418      418              
  Lines       40478    40477       -1     
==========================================
+ Hits        20575    20663      +88     
+ Misses      17645    17552      -93     
- Partials     2258     2262       +4     
Flag Coverage Δ
unittest 51.04% <57.14%> (+0.21%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
pkg/util/cnr_topology.go 84.84% <ø> (ø)
...nager/fetcher/kubelet/topology/topology_adapter.go 54.36% <57.14%> (ø)

... and 13 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@luomingmeng luomingmeng added the workflow/merge-ready merge-ready: code is ready and can be merged label Jul 27, 2023
@waynepeking348 waynepeking348 merged commit 4e5a93d into kubewharf:main Jul 27, 2023
luomingmeng added a commit to luomingmeng/katalyst-core that referenced this pull request Oct 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore workflow/merge-ready merge-ready: code is ready and can be merged workflow/need-review review: test succeeded, need to review
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

3 participants