Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhancement(eviction): heartbeat in cpu pressure eviction plugin #184

Merged

Conversation

zzzzhhb
Copy link
Collaborator

@zzzzhhb zzzzhhb commented Aug 4, 2023

What type of PR is this?

Enhancements

What this PR does / why we need it:

add heartbeat for cpu pressure eviction plugin

Which issue(s) this PR fixes:

Special notes for your reviewer:

@codecov
Copy link

codecov bot commented Aug 4, 2023

Codecov Report

Patch coverage has no change and project coverage change: +0.30% 🎉

Comparison is base (ac141a3) 51.17% compared to head (7f1e24e) 51.47%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #184      +/-   ##
==========================================
+ Coverage   51.17%   51.47%   +0.30%     
==========================================
  Files         422      422              
  Lines       40768    40772       +4     
==========================================
+ Hits        20863    20988     +125     
+ Misses      17624    17489     -135     
- Partials     2281     2295      +14     
Flag Coverage Δ
unittest 51.47% <0.00%> (+0.30%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
...gins/cpu/dynamicpolicy/cpueviction/cpu_eviciton.go 0.00% <0.00%> (ø)

... and 15 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zzzzhhb zzzzhhb added enhancement New feature or request workflow/need-review review: test succeeded, need to review workflow/merge-ready merge-ready: code is ready and can be merged labels Aug 4, 2023
@waynepeking348 waynepeking348 merged commit a049d1f into kubewharf:main Aug 4, 2023
@waynepeking348 waynepeking348 deleted the add_heartbeat_for_cpu_eviction_plugin branch August 4, 2023 07:37
@waynepeking348 waynepeking348 restored the add_heartbeat_for_cpu_eviction_plugin branch August 4, 2023 07:37
luomingmeng pushed a commit to luomingmeng/katalyst-core that referenced this pull request Oct 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request workflow/merge-ready merge-ready: code is ready and can be merged workflow/need-review review: test succeeded, need to review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants