Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kcc support priority and its allowed selector key list #189

Conversation

luomingmeng
Copy link
Collaborator

What type of PR is this?

Features

What this PR does / why we need it:

To enhance the functionality of KCC (Katalyst Custom Configuration), it is necessary to extend its support for multiple node selector keys instead of just one. This is required because in certain scenarios, the node configuration may be differentiated by multiple labels, such as machine type, sub-cluster, physical space, and other attributes.

By allowing the involvement of multiple keys in the selector, there is a higher likelihood of configuration overlap. To address this, we propose introducing a priority system that enables the overriding of lower priority configurations in specific cases, such as during degradation.

@luomingmeng luomingmeng added enhancement New feature or request workflow/merge-hold merge-hold: code is ready but still has dependency labels Aug 7, 2023
@luomingmeng luomingmeng added this to the v0.3 milestone Aug 7, 2023
@luomingmeng luomingmeng self-assigned this Aug 7, 2023
@luomingmeng luomingmeng force-pushed the dev/kcc_support_priority_and_selector_key_list branch from 085ae1b to e289331 Compare August 7, 2023 09:10
@codecov
Copy link

codecov bot commented Aug 7, 2023

Codecov Report

Patch coverage: 54.08% and project coverage change: +0.09% 🎉

Comparison is base (0d40f83) 51.57% compared to head (bbf20e3) 51.66%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #189      +/-   ##
==========================================
+ Coverage   51.57%   51.66%   +0.09%     
==========================================
  Files         430      431       +1     
  Lines       40919    41030     +111     
==========================================
+ Hits        21102    21199      +97     
- Misses      17512    17526      +14     
  Partials     2305     2305              
Flag Coverage Δ
unittest 51.66% <54.08%> (+0.09%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
pkg/controller/kcc/util/kcct.go 25.33% <0.00%> (-0.83%) ⬇️
pkg/controller/kcc/kcct.go 32.43% <55.55%> (+3.31%) ⬆️
pkg/controller/kcc/kcc.go 55.45% <68.18%> (+0.80%) ⬆️
pkg/util/kcct.go 69.09% <100.00%> (+0.86%) ⬆️

... and 16 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@luomingmeng luomingmeng force-pushed the dev/kcc_support_priority_and_selector_key_list branch 5 times, most recently from 40084d1 to 076373f Compare August 7, 2023 15:10
@luomingmeng luomingmeng marked this pull request as ready for review August 8, 2023 02:14
@luomingmeng luomingmeng added workflow/need-review review: test succeeded, need to review and removed workflow/merge-hold merge-hold: code is ready but still has dependency labels Aug 8, 2023
csfldf
csfldf previously approved these changes Aug 8, 2023
@luomingmeng luomingmeng force-pushed the dev/kcc_support_priority_and_selector_key_list branch from 076373f to bbf20e3 Compare August 8, 2023 07:39
@waynepeking348 waynepeking348 merged commit 785d49b into kubewharf:main Aug 8, 2023
luomingmeng added a commit to luomingmeng/katalyst-core that referenced this pull request Oct 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request workflow/need-review review: test succeeded, need to review
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

3 participants