fix kcc and target resource modify no trigger others update #196
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luomingmeng
added
bug
waynepeking348
previously approved these changes
Aug 9, 2023
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #196 +/- ##
==========================================
+ Coverage 51.79% 52.17% +0.37%
==========================================
Files 436 437 +1
Lines 41948 42035 +87
==========================================
+ Hits 21728 21931 +203
+ Misses 17871 17689 -182
- Partials 2349 2415 +66
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
luomingmeng
force-pushed
the
dev/fix_kcc_modify_no_trigger_update
branch
from
60f6333 to
63208a6
Compare
luomingmeng
force-pushed
the
dev/fix_kcc_modify_no_trigger_update
branch
from
63208a6 to
8ad3c19
Compare
waynepeking348
approved these changes
Aug 9, 2023
csfldf
approved these changes
Aug 9, 2023
luomingmeng
added
the
workflow/merge-ready
luomingmeng
added a commit
to luomingmeng/katalyst-core
that referenced
this pull request
Oct 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Bug fixes
What this PR does / why we need it:
Fix bugs where modifying KCC or the target resource does not trigger updates for other KCCs or other target resources, requiring manual triggering of their updates.