Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(qrm): modify memory control knob handler signature to add more utils convenient for handlers registered out of policy itself #199

Merged
merged 1 commit into from
Aug 10, 2023

Conversation

csfldf
Copy link
Collaborator

@csfldf csfldf commented Aug 10, 2023

feat(qrm): modify memory control knob handler signature to add more utils convenient for handlers registered out of policy itself

…tils convenient for handlers registered out of policy itself
@csfldf csfldf added the workflow/need-review review: test succeeded, need to review label Aug 10, 2023
@csfldf csfldf self-assigned this Aug 10, 2023
@codecov
Copy link

codecov bot commented Aug 10, 2023

Codecov Report

Patch coverage: 70.58% and project coverage change: +0.58% 🎉

Comparison is base (1e81e70) 51.91% compared to head (4af17a5) 52.50%.
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #199      +/-   ##
==========================================
+ Coverage   51.91%   52.50%   +0.58%     
==========================================
  Files         437      437              
  Lines       42005    42053      +48     
==========================================
+ Hits        21808    22078     +270     
+ Misses      17837    17556     -281     
- Partials     2360     2419      +59     
Flag Coverage Δ
unittest 52.50% <70.58%> (+0.58%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
pkg/agent/qrm-plugins/cpu/dynamicpolicy/policy.go 44.97% <0.00%> (-0.06%) ⬇️
...ns/cpu/dynamicpolicy/policy_allocation_handlers.go 42.36% <ø> (-0.08%) ⬇️
...lugins/cpu/dynamicpolicy/policy_advisor_handler.go 35.30% <33.33%> (ø)
...ins/memory/dynamicpolicy/policy_advisor_handler.go 50.20% <72.09%> (+3.75%) ⬆️
...g/agent/qrm-plugins/memory/dynamicpolicy/policy.go 61.12% <75.00%> (+0.26%) ⬆️
...licy/memoryadvisor/policy_control_knob_handlers.go 70.00% <76.47%> (+0.76%) ⬆️

... and 17 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@csfldf csfldf added workflow/merge-ready merge-ready: code is ready and can be merged and removed workflow/need-review review: test succeeded, need to review labels Aug 10, 2023
@waynepeking348 waynepeking348 merged commit c17cf0e into kubewharf:main Aug 10, 2023
luomingmeng pushed a commit to luomingmeng/katalyst-core that referenced this pull request Oct 11, 2024
…tils convenient for handlers registered out of policy itself (kubewharf#199)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
workflow/merge-ready merge-ready: code is ready and can be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants