Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(*): fix doc and memory QRM plugin #2

Merged
merged 2 commits into from
Apr 10, 2023

Conversation

caohe
Copy link
Member

@caohe caohe commented Mar 13, 2023

What type of PR is this?

Bug fixes

What this PR does / why we need it:

  • some fixes to README and proposals
  • fix incorrect for-range closure usage in memory QRM plugin

Which issue(s) this PR fixes:

Special notes for your reviewer:

@caohe caohe requested a review from waynepeking348 March 13, 2023 07:56
@caohe
Copy link
Member Author

caohe commented Mar 13, 2023

@pendoragon Maybe we should consider implementing a separate pipeline for pull requests?

@caohe caohe added this to the v0.1 milestone Mar 13, 2023
@caohe caohe added the bug Something isn't working label Mar 13, 2023
@pendoragon
Copy link
Collaborator

@caohe sure, guess linting, unit test and build will suffice for a pull request

@codecov
Copy link

codecov bot commented Apr 10, 2023

Codecov Report

Patch coverage has no change and project coverage change: -1.00 ⚠️

Comparison is base (33acfa6) 42.97% compared to head (96dd308) 41.98%.

❗ Current head 96dd308 differs from pull request most recent head 93dde98. Consider uploading reports for the commit 93dde98 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main       #2      +/-   ##
==========================================
- Coverage   42.97%   41.98%   -1.00%     
==========================================
  Files         145      146       +1     
  Lines       23523    23538      +15     
==========================================
- Hits        10110     9882     -228     
- Misses      12090    12364     +274     
+ Partials     1323     1292      -31     
Flag Coverage Δ
unittest 41.98% <0.00%> (-1.00%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...g/agent/qrm-plugins/memory/dynamicpolicy/policy.go 30.39% <0.00%> (ø)

... and 16 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@caohe caohe force-pushed the fix-doc-and-qrm branch from de8f299 to 96dd308 Compare April 10, 2023 07:25
@caohe caohe force-pushed the fix-doc-and-qrm branch 20 times, most recently from d9021a5 to f019e73 Compare April 10, 2023 11:42
@caohe caohe force-pushed the fix-doc-and-qrm branch 7 times, most recently from 896ba2c to 4dbf266 Compare April 10, 2023 11:53
Signed-off-by: caohe <caohe9603@gmail.com>
@caohe caohe force-pushed the fix-doc-and-qrm branch from 4dbf266 to 93dde98 Compare April 10, 2023 12:08
@waynepeking348 waynepeking348 merged commit e4ac753 into kubewharf:main Apr 10, 2023
@caohe caohe deleted the fix-doc-and-qrm branch April 10, 2023 12:35
kapybar4 added a commit to kapybar4/katalyst-core that referenced this pull request Jun 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants