Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add node name label for pod metric in kcmas #20

Merged

Conversation

waynepeking348
Copy link
Collaborator

@waynepeking348 waynepeking348 commented Apr 17, 2023

What type of PR is this?

Enhancements

What this PR does / why we need it:

add node name as selectors for pod-level metric in kcmas, to reduce to overhead of client-side matching for pod and node

@waynepeking348 waynepeking348 added the enhancement New feature or request label Apr 17, 2023
@waynepeking348 waynepeking348 added this to the v0.1 milestone Apr 17, 2023
@codecov
Copy link

codecov bot commented Apr 17, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.02 ⚠️

Comparison is base (c8fffa8) 51.02% compared to head (b6d938f) 51.00%.

❗ Current head b6d938f differs from pull request most recent head 7cbf670. Consider uploading reports for the commit 7cbf670 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #20      +/-   ##
==========================================
- Coverage   51.02%   51.00%   -0.02%     
==========================================
  Files         312      312              
  Lines       31798    31802       +4     
==========================================
- Hits        16224    16221       -3     
- Misses      13660    13665       +5     
- Partials     1914     1916       +2     
Flag Coverage Δ
unittest 51.00% <100.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...sysadvisor/plugin/metric-emitter/syncer/pod/pod.go 66.42% <100.00%> (+0.98%) ⬆️

... and 3 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@caohe caohe modified the milestones: v0.1, v0.2 Apr 19, 2023
@waynepeking348 waynepeking348 added the workflow/draft draft: no need to review label Apr 20, 2023
@waynepeking348 waynepeking348 force-pushed the add_node_name_in_pod_metric branch from 7105805 to b6d938f Compare April 20, 2023 11:15
@waynepeking348 waynepeking348 force-pushed the add_node_name_in_pod_metric branch from b6d938f to 7cbf670 Compare April 20, 2023 11:18
@waynepeking348 waynepeking348 added workflow/need-review review: test succeeded, need to review and removed workflow/draft draft: no need to review labels Apr 20, 2023
@waynepeking348 waynepeking348 added workflow/merge-ready merge-ready: code is ready and can be merged and removed workflow/need-review review: test succeeded, need to review labels Apr 21, 2023
@waynepeking348 waynepeking348 merged commit b916790 into kubewharf:main Apr 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request workflow/merge-ready merge-ready: code is ready and can be merged
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants