feat(spd): make spd indicator plugins configurable #204
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
waynepeking348
previously approved these changes
Aug 14, 2023
luomingmeng
previously approved these changes
Aug 14, 2023
Signed-off-by: linzhecheng <linzhecheng@bytedance.com>
cheney-lin
dismissed stale reviews from luomingmeng and waynepeking348
via
5774e21
cheney-lin
force-pushed
the
dev/spd_indicator_plugins
branch
from
ca9828d to
5774e21
Compare
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #204 +/- ##
==========================================
+ Coverage 52.27% 52.52% +0.24%
==========================================
Files 437 437
Lines 42091 42096 +5
==========================================
+ Hits 22004 22111 +107
+ Misses 17670 17566 -104
- Partials 2417 2419 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
waynepeking348
approved these changes
Aug 14, 2023
luomingmeng
approved these changes
Aug 14, 2023
luomingmeng
pushed a commit
to luomingmeng/katalyst-core
that referenced
this pull request
Oct 11, 2024
Signed-off-by: linzhecheng <linzhecheng@bytedance.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Enhancements
What this PR does / why we need it:
Which issue(s) this PR fixes:
Special notes for your reviewer: