Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(overcommit): add node overcommit webhook #229

Merged

Conversation

WangZzzhe
Copy link
Collaborator

What type of PR is this?

Features

What this PR does / why we need it:

add a node mutatingwebhook.
this webhook hijack node.status updating requests, amplify node allocatable and capacity by node overcommitment annotations, which supports node resource overcommitment without users' awareness

Which issue(s) this PR fixes:

#214

@caohe caohe added enhancement New feature or request workflow/draft draft: no need to review labels Aug 22, 2023
@caohe caohe added this to the v0.4 milestone Aug 22, 2023
@caohe
Copy link
Member

caohe commented Aug 22, 2023

@WangZzzhe Could u please rebase the main branch and resolve the conflict of go.mod?

@WangZzzhe WangZzzhe force-pushed the dev/node-overcommit-webhook branch from ad8ab9a to 0d207ee Compare August 22, 2023 03:24
@WangZzzhe
Copy link
Collaborator Author

@WangZzzhe Could u please rebase the main branch and resolve the conflict of go.mod?

@caohe Done. And the replacement of katalyst-api will be removed before merge

@codecov
Copy link

codecov bot commented Aug 22, 2023

Codecov Report

Attention: 51 lines in your changes are missing coverage. Please review.

Comparison is base (3a61f04) 53.13% compared to head (34ec452) 53.26%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #229      +/-   ##
==========================================
+ Coverage   53.13%   53.26%   +0.12%     
==========================================
  Files         400      402       +2     
  Lines       43803    43969     +166     
==========================================
+ Hits        23275    23418     +143     
- Misses      17964    17969       +5     
- Partials     2564     2582      +18     
Flag Coverage Δ
unittest 53.26% <69.27%> (+0.12%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
pkg/util/native/resources.go 62.50% <78.57%> (+3.62%) ⬆️
pkg/webhook/mutating/node/allocatable_mutator.go 83.09% <83.09%> (ø)
pkg/webhook/mutating/node/node.go 50.74% <50.74%> (ø)

... and 14 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@WangZzzhe WangZzzhe force-pushed the dev/node-overcommit-webhook branch 3 times, most recently from 83e02a2 to 6dcf6c7 Compare August 23, 2023 08:44
@WangZzzhe WangZzzhe force-pushed the dev/node-overcommit-webhook branch from 6dcf6c7 to e3fbcc8 Compare September 6, 2023 08:11
@WangZzzhe WangZzzhe force-pushed the dev/node-overcommit-webhook branch from e3fbcc8 to 9063bf9 Compare October 10, 2023 02:49
@WangZzzhe WangZzzhe force-pushed the dev/node-overcommit-webhook branch from 9063bf9 to 34ec452 Compare October 10, 2023 03:09
@caohe caohe added workflow/need-review review: test succeeded, need to review and removed workflow/draft draft: no need to review labels Oct 25, 2023
@waynepeking348 waynepeking348 added the workflow/merge-ready merge-ready: code is ready and can be merged label Oct 25, 2023
@waynepeking348 waynepeking348 merged commit 84e9dea into kubewharf:main Oct 25, 2023
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request workflow/merge-ready merge-ready: code is ready and can be merged workflow/need-review review: test succeeded, need to review
Projects
Status: 🏗 In progress
Development

Successfully merging this pull request may close these issues.

3 participants