Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refine implementation of sysadvisor policies #25

Merged
merged 1 commit into from
Apr 19, 2023

Conversation

waynepeking348
Copy link
Collaborator

What type of PR is this?

Style

What this PR does / why we need it:

change the elements in sys-advisor policies to small lowercases to avoid unexpected writes

@codecov
Copy link

codecov bot commented Apr 18, 2023

Codecov Report

Patch coverage: 87.23% and project coverage change: +8.62 🎉

Comparison is base (b94d82c) 42.76% compared to head (b35a461) 51.39%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #25      +/-   ##
==========================================
+ Coverage   42.76%   51.39%   +8.62%     
==========================================
  Files         143      302     +159     
  Lines       23374    31175    +7801     
==========================================
+ Hits         9997    16022    +6025     
- Misses      12058    13303    +1245     
- Partials     1319     1850     +531     
Flag Coverage Δ
unittest 51.39% <87.23%> (+8.62%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/agent/sysadvisor/metacache/metacache.go 84.00% <ø> (ø)
...resource/memory/headroompolicy/policy_canonical.go 78.26% <75.00%> (ø)
...urce/cpu/region/headroompolicy/policy_canonical.go 64.51% <80.00%> (ø)
...rce/cpu/region/provisionpolicy/policy_canonical.go 75.00% <80.00%> (ø)
...ware/resource/memory/headroompolicy/policy_base.go 83.33% <80.00%> (ø)
...resource/cpu/region/provisionpolicy/policy_base.go 91.30% <93.33%> (ø)
.../resource/cpu/region/headroompolicy/policy_base.go 100.00% <100.00%> (ø)

... and 222 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@waynepeking348 waynepeking348 merged commit ef99e65 into kubewharf:main Apr 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants