Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(eviction): support container killer #257

Merged
merged 1 commit into from
Sep 5, 2023

Conversation

zzzzhhb
Copy link
Collaborator

@zzzzhhb zzzzhhb commented Sep 4, 2023

What type of PR is this?

Features

What this PR does / why we need it:

This PR supports a new kind of pod killer which directly stop container instead of evicting or killing the pod. The goal is to avoid the pod to be rescheduled. It has benefits in certain scenarios like heavy and stateful services. For example, the service might need load a great mount of data into volumes and killing or evicting pod will cause the reload of data.

Which issue(s) this PR fixes:

Special notes for your reviewer:

@zzzzhhb zzzzhhb added enhancement New feature or request workflow/need-review review: test succeeded, need to review labels Sep 4, 2023
@codecov
Copy link

codecov bot commented Sep 4, 2023

Codecov Report

Patch coverage: 58.90% and project coverage change: +0.23% 🎉

Comparison is base (268d46c) 52.86% compared to head (cd7d957) 53.10%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #257      +/-   ##
==========================================
+ Coverage   52.86%   53.10%   +0.23%     
==========================================
  Files         437      437              
  Lines       42486    42547      +61     
==========================================
+ Hits        22460    22594     +134     
+ Misses      17575    17499      -76     
- Partials     2451     2454       +3     
Flag Coverage Δ
unittest 53.10% <58.90%> (+0.23%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
cmd/katalyst-agent/app/agent/eviction.go 0.00% <0.00%> (ø)
pkg/config/agent/eviction/eviciton_base.go 100.00% <ø> (ø)
...talyst-agent/app/options/eviction/eviction_base.go 45.83% <40.00%> (-0.44%) ⬇️
pkg/agent/evictionmanager/podkiller/killer.go 64.20% <63.63%> (+0.17%) ⬆️
pkg/agent/evictionmanager/manager.go 43.03% <68.42%> (+0.99%) ⬆️

... and 15 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zzzzhhb zzzzhhb requested a review from csfldf September 4, 2023 12:48
@zzzzhhb zzzzhhb added the workflow/merge-ready merge-ready: code is ready and can be merged label Sep 5, 2023
@waynepeking348 waynepeking348 merged commit faa61d7 into kubewharf:main Sep 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request workflow/merge-ready merge-ready: code is ready and can be merged workflow/need-review review: test succeeded, need to review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants