Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix KatalystCustomConfigTargetHandler to avoid cnc being cleared when cache no synced in restart #265

Merged

Conversation

luomingmeng
Copy link
Collaborator

What type of PR is this?

Bug fixes

What this PR does / why we need it:

cnc/kcc/kcct controller should wait KatalystCustomConfigTargetHandler cache synced to aviod unexpectly behavior when cache no synced in restart.

…being cleared when cache no synced in restart
@luomingmeng luomingmeng added the bug Something isn't working label Sep 8, 2023
@luomingmeng luomingmeng self-assigned this Sep 8, 2023
@codecov
Copy link

codecov bot commented Sep 8, 2023

Codecov Report

Patch coverage: 80.00% and project coverage change: +0.31% 🎉

Comparison is base (268d46c) 52.86% compared to head (17e27e0) 53.17%.
Report is 11 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #265      +/-   ##
==========================================
+ Coverage   52.86%   53.17%   +0.31%     
==========================================
  Files         437      443       +6     
  Lines       42486    43043     +557     
==========================================
+ Hits        22460    22888     +428     
- Misses      17575    17665      +90     
- Partials     2451     2490      +39     
Flag Coverage Δ
unittest 53.17% <80.00%> (+0.31%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
pkg/controller/kcc/target/target_handler.go 43.62% <75.00%> (+1.06%) ⬆️
pkg/controller/kcc/cnc.go 54.46% <100.00%> (+0.21%) ⬆️
pkg/controller/kcc/kcc.go 65.61% <100.00%> (+3.83%) ⬆️
pkg/controller/kcc/kcct.go 58.31% <100.00%> (+0.10%) ⬆️

... and 38 files with indirect coverage changes

☔ View full report in Codecov by Sentry.

📢 Have feedback on the report? Share it here.

@waynepeking348 waynepeking348 added workflow/need-review review: test succeeded, need to review workflow/merge-ready merge-ready: code is ready and can be merged labels Sep 8, 2023
@luomingmeng luomingmeng marked this pull request as ready for review September 8, 2023 07:35
@waynepeking348 waynepeking348 merged commit a874fac into kubewharf:main Sep 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working workflow/merge-ready merge-ready: code is ready and can be merged workflow/need-review review: test succeeded, need to review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants