Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(sysadvisor): bind reclaim_cores contianers to non-exclusive … #275

Merged
merged 1 commit into from
Sep 13, 2023

Conversation

cheney-lin
Copy link
Member

…numas

What type of PR is this?

Enhancements

What this PR does / why we need it:

Which issue(s) this PR fixes:

Special notes for your reviewer:

@cheney-lin cheney-lin force-pushed the dev/bind_reclaim_cores branch from 3f650a4 to 931278a Compare September 12, 2023 11:36
@codecov
Copy link

codecov bot commented Sep 12, 2023

Codecov Report

Patch coverage: 55.88% and project coverage change: +0.02% 🎉

Comparison is base (8873dde) 53.19% compared to head (dbe322f) 53.21%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #275      +/-   ##
==========================================
+ Coverage   53.19%   53.21%   +0.02%     
==========================================
  Files         444      444              
  Lines       43177    43203      +26     
==========================================
+ Hits        22967    22990      +23     
+ Misses      17719    17711       -8     
- Partials     2491     2502      +11     
Flag Coverage Δ
unittest 53.21% <55.88%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
...n/qosaware/resource/memory/plugin/memset_binder.go 74.64% <55.88%> (-17.86%) ⬇️

... and 9 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

…numas

Signed-off-by: linzhecheng <linzhecheng@bytedance.com>
@cheney-lin cheney-lin force-pushed the dev/bind_reclaim_cores branch from 931278a to dbe322f Compare September 12, 2023 11:44
@cheney-lin cheney-lin changed the title WIP refactor(sysadvisor): bind reclaim_cores contianers to non-exclusive … refactor(sysadvisor): bind reclaim_cores contianers to non-exclusive … Sep 12, 2023
@cheney-lin cheney-lin added enhancement New feature or request workflow/need-review review: test succeeded, need to review labels Sep 12, 2023
@waynepeking348 waynepeking348 merged commit 7f75565 into kubewharf:main Sep 13, 2023
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request workflow/need-review review: test succeeded, need to review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants