enhancement(sysadvisor): skip the containers if cache usage less then… #297
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cheney-lin
force-pushed
the
dev/skip_low_cache_usage
branch
from
2b13081 to
8acce7e
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #297 +/- ##
==========================================
- Coverage 53.39% 53.31% -0.09%
==========================================
Files 401 403 +2
Lines 43913 43998 +85
==========================================
+ Hits 23448 23458 +10
- Misses 17878 17966 +88
+ Partials 2587 2574 -13
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
cheney-lin
force-pushed
the
dev/skip_low_cache_usage
branch
3 times, most recently
from
a52259b to
7088198
Compare
cheney-lin
added
enhancement
| @@ -247,6 +247,8 @@ func (ra *memoryResourceAdvisor) detectNUMAPressure(numaID int) (*types.MemoryPr | |||
| if free < criticalWatermark { | |||
| pressureState = types.MemoryPressureDropCache | |||
| targetReclaimed.Set(int64(2*criticalWatermark - free)) | |||
| } else if free < 2*criticalWatermark { | |||
There was a problem hiding this comment.
for those magic numbers, pls use const vars (along with a brief introduction)
| containers := make([]*types.ContainerInfo, 0) | ||
| cp.metaReader.RangeContainer(func(podUID string, containerName string, containerInfo *types.ContainerInfo) bool { | ||
| if cp.reclaimedContainersFilter(containerInfo) { | ||
| if cp.reclaimedContainersFilter(containerInfo, -1, minCacheUtilizationThreshold) { |
There was a problem hiding this comment.
pls use const vars defined in pb package instead of -1 here
… threshold when reaping cache Signed-off-by: linzhecheng <linzhecheng@bytedance.com>
cheney-lin
force-pushed
the
dev/skip_low_cache_usage
branch
from
7088198 to
78a2d7b
Compare
waynepeking348
approved these changes
Oct 17, 2023
sun-yuliang
approved these changes
Oct 18, 2023
cheney-lin
added
workflow/merge-ready
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… threshold when reaping cache
What type of PR is this?
Enhancements
What this PR does / why we need it:
Which issue(s) this PR fixes:
Special notes for your reviewer: