feat: node resource topology scheduler plugin #298
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WangZzzhe
force-pushed
the
dev/scheduler-noderesourcetopology
branch
from
fc46d5b to
c74515d
Compare
WangZzzhe
force-pushed
the
dev/scheduler-noderesourcetopology
branch
2 times, most recently
from
cf48b9c to
d292543
Compare
WangZzzhe
force-pushed
the
dev/scheduler-noderesourcetopology
branch
3 times, most recently
from
48b985c to
16fe377
Compare
|
@caohe pls take your time to confirm whether we can merge this pr |
Sure, we can merge this pr first kubewharf/enhanced-k8s#12 |
enhanced-k8s has been merged, but the api still requires another approve, so you may need to approve that firstly @caohe |
20 tasks
WangZzzhe
force-pushed
the
dev/scheduler-noderesourcetopology
branch
from
16fe377 to
3690c5e
Compare
caohe
reviewed
Dec 27, 2023
| return []framework.ClusterEvent{ | ||
| {Resource: framework.Pod, ActionType: framework.Delete}, | ||
| {Resource: framework.Node, ActionType: framework.Add | framework.UpdateNodeAllocatable}, | ||
| {Resource: framework.GVK(nrtGVK), ActionType: framework.Add | framework.Update}, |
There was a problem hiding this comment.
Is this CRD nrt or cnr?
cnr, it has been updated
caohe
reviewed
Dec 27, 2023
| "github.com/kubewharf/katalyst-core/pkg/scheduler/util" | ||
| ) | ||
|
|
||
| func (tm *TopologyMatch) Reserve(ctx context.Context, state *framework.CycleState, pod *corev1.Pod, nodeName string) *framework.Status { |
There was a problem hiding this comment.
How do we implement "pessimistic allocation" if multiple numa nodes are needed?
caohe
approved these changes
Dec 27, 2023
waynepeking348
approved these changes
Dec 27, 2023
luomingmeng
approved these changes
Dec 28, 2023
csfldf
approved these changes
Dec 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Enhancements
What this PR does / why we need it:
add topologyMatch plugin to support topology-aware scheduling for both nativePolicy and dynamicPolicy
nativePolicy + single-numa-node,
dynamicPolicy + dedicated_cores + numaBinding + single-numa-node,
dynamicPolicy + dedicated_cores + numaBinding + numaExclusive + single-numa-node,
dynamicPolicy + dedicated_cores + numaBinding + numeric,
dynamicPolicy + dedicated_cores + numaBinding + numaExclusive + numeric
are supported.
Which issue(s) this PR fixes:
#160