chore(*): add a CI pipeline to check pull requests #3
Conversation
| @@ -9,7 +9,6 @@ on: | |||
| push: | |||
| branches: [ 'master', 'main', 'release-*' ] | |||
| # Publish semver tags as releases. | |||
| pull_request: {} | |||
There was a problem hiding this comment.
maybe these lines can be removed as well?
https://github.com/kubewharf/katalyst-core/pull/3/files#diff-87db21a973eed4fef5f32b267aa60fcee5cbdf03c67fafdc2a9b553bb0b15f34R78-R82
and we can change this line to push: true
https://github.com/kubewharf/katalyst-core/pull/3/files#diff-87db21a973eed4fef5f32b267aa60fcee5cbdf03c67fafdc2a9b553bb0b15f34R93
There was a problem hiding this comment.
Yes, I think these lines are no longer necessary, and I have modified them.
.github/workflows/ci.yml
Outdated
| jobs: | ||
| lint: | ||
| name: Lint | ||
| runs-on: ubuntu-18.04 |
There was a problem hiding this comment.
seems ubuntu-18.04 will be deprecated soon actions/runner-images#6002
use ubuntu-latest instead?
There was a problem hiding this comment.
"ubuntu-latest" refers to version 22.04, in which cgroup v2 is enabled by default and causes some unit tests to fail. Therefore, I switched the system version to the older 18.04. However, I also tried version 20.04 and it worked as well, which I consider to be a viable option.
Signed-off-by: caohe <caohe9603@gmail.com>
What type of PR is this?
Chore
What this PR does / why we need it:
The original pipeline is used for building and pushing images during the release process. Therefore, we have added a new CI pipeline to check pull requests, which includes linting, building, and unit testing.
Which issue(s) this PR fixes:
Special notes for your reviewer: