-
Notifications
You must be signed in to change notification settings - Fork 110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
enhancement(auth): basic auth use kcc as backend #305
Conversation
e7710ae
to
4c97416
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #305 +/- ##
==========================================
- Coverage 53.39% 53.35% -0.04%
==========================================
Files 401 401
Lines 43913 43924 +11
==========================================
- Hits 23448 23437 -11
- Misses 17878 17908 +30
+ Partials 2587 2579 -8
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
return verify(authInfo, targetResource, s.subjectToPermissions) | ||
} | ||
|
||
func (s *dynamicConfAccessControl) updateAuthInfoFromSecret() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this function rename toupdateAuthInfoFromDynamicConf
maybe more properly?
) | ||
|
||
const ( | ||
secretSyncInterval = 5 * time.Minute |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the interval sync auth config from dynamic config may be too long, just 30s is ok, because the dynamic config use local cache
99ebccf
to
852551f
Compare
What type of PR is this?
Enhancements
What this PR does / why we need it:
use kcc as authentication backend store
Which issue(s) this PR fixes:
Special notes for your reviewer: