-
Notifications
You must be signed in to change notification settings - Fork 109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(sysadvisor): implement borwein algorithm #307
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #307 +/- ##
==========================================
- Coverage 53.39% 53.39% -0.01%
==========================================
Files 401 412 +11
Lines 43913 46109 +2196
==========================================
+ Hits 23448 24620 +1172
- Misses 17878 18714 +836
- Partials 2587 2775 +188
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
606d9a0
to
1648581
Compare
pkg/agent/sysadvisor/plugin/inference/modelresultfetcher/borwein/borwein.go
Outdated
Show resolved
Hide resolved
pkg/agent/sysadvisor/plugin/inference/modelresultfetcher/borwein/borwein.go
Outdated
Show resolved
Hide resolved
type GetContainerFeatureValueFunc func(podUID string, containerName string, featureName string, | ||
metaServer *metaserver.MetaServer, metaReader metacache.MetaReader) (string, error) | ||
|
||
var GetNodeFeatureValue GetNodeFeatureValueFunc = NativeGetNodeFeatureValue |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- GetNodeFeatureValue -> getNodeFeatureValue
- should we lock the update actions for setter functions?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
since function type variable assignment is atomic in assembly code,maybe we don't need to lock setter functions currently.
pkg/agent/sysadvisor/plugin/inference/models/borwein/inferencesvc/inference_svc.proto
Show resolved
Hide resolved
pkg/agent/sysadvisor/plugin/qosaware/resource/helper/modelctrl/borwein/borwein.go
Outdated
Show resolved
Hide resolved
pkg/agent/sysadvisor/plugin/inference/modelresultfetcher/model_result_fetcher.go
Show resolved
Hide resolved
pkg/agent/sysadvisor/plugin/inference/modelresultfetcher/borwein/borwein.go
Show resolved
Hide resolved
82500b9
to
a584c7f
Compare
a584c7f
to
3302e8f
Compare
feat(sysadvisor): implement borwein algorithm