Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(sysadvisor): implement borwein algorithm #307

Merged
merged 3 commits into from
Oct 19, 2023

Conversation

csfldf
Copy link
Collaborator

@csfldf csfldf commented Oct 8, 2023

feat(sysadvisor): implement borwein algorithm

@csfldf csfldf self-assigned this Oct 8, 2023
@codecov
Copy link

codecov bot commented Oct 8, 2023

Codecov Report

Attention: 993 lines in your changes are missing coverage. Please review.

Comparison is base (35c0eb0) 53.39% compared to head (3302e8f) 53.39%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #307      +/-   ##
==========================================
- Coverage   53.39%   53.39%   -0.01%     
==========================================
  Files         401      412      +11     
  Lines       43913    46109    +2196     
==========================================
+ Hits        23448    24620    +1172     
- Misses      17878    18714     +836     
- Partials     2587     2775     +188     
Flag Coverage Δ
unittest 53.39% <54.76%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
pkg/agent/qrm-plugins/cpu/util/util.go 71.29% <100.00%> (+0.82%) ⬆️
...ference/modelresultfetcher/model_result_fetcher.go 100.00% <100.00%> (ø)
pkg/agent/sysadvisor/plugin/metacache/metacache.go 54.76% <100.00%> (ø)
pkg/agent/sysadvisor/plugin/plugin.go 75.00% <ø> (ø)
pkg/agent/sysadvisor/plugin/qosaware/qos_aware.go 73.91% <100.00%> (ø)
...pp/options/sysadvisor/qosaware/qos_aware_plugin.go 66.66% <66.66%> (ø)
...ns/sysadvisor/qosaware/resource/cpu/cpu_advisor.go 72.22% <85.71%> (-0.86%) ⬇️
...st-agent/app/options/sysadvisor/sysadvisor_base.go 48.93% <66.66%> (+1.20%) ⬆️
...sysadvisor/plugin/metric-emitter/metric_emitter.go 84.37% <50.00%> (-5.95%) ⬇️
pkg/agent/sysadvisor/sysadvisor.go 40.00% <50.00%> (-37.22%) ⬇️
... and 12 more

... and 19 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@waynepeking348 waynepeking348 added workflow/merge-hold merge-hold: code is ready but still has dependency enhancement New feature or request labels Oct 8, 2023
@waynepeking348 waynepeking348 added this to the v0.4 milestone Oct 8, 2023
@csfldf csfldf force-pushed the dev/bowein_draft branch 6 times, most recently from 606d9a0 to 1648581 Compare October 9, 2023 02:24
@csfldf csfldf added the workflow/need-review review: test succeeded, need to review label Oct 9, 2023
pkg/agent/sysadvisor/metacache/metacache.go Show resolved Hide resolved
type GetContainerFeatureValueFunc func(podUID string, containerName string, featureName string,
metaServer *metaserver.MetaServer, metaReader metacache.MetaReader) (string, error)

var GetNodeFeatureValue GetNodeFeatureValueFunc = NativeGetNodeFeatureValue
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. GetNodeFeatureValue -> getNodeFeatureValue
  2. should we lock the update actions for setter functions?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

since function type variable assignment is atomic in assembly code,maybe we don't need to lock setter functions currently.

@csfldf csfldf force-pushed the dev/bowein_draft branch 2 times, most recently from 82500b9 to a584c7f Compare October 13, 2023 13:55
@sun-yuliang sun-yuliang removed the workflow/merge-hold merge-hold: code is ready but still has dependency label Oct 17, 2023
@csfldf csfldf added workflow/merge-ready merge-ready: code is ready and can be merged and removed workflow/need-review review: test succeeded, need to review labels Oct 19, 2023
@waynepeking348 waynepeking348 merged commit a5e0e3d into kubewharf:main Oct 19, 2023
11 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request workflow/merge-ready merge-ready: code is ready and can be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants