Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

decode metric list according to metric name whether is aggregator metric #317

Merged
merged 1 commit into from
Oct 18, 2023

Conversation

luomingmeng
Copy link
Collaborator

What type of PR is this?

Bug fixes

What this PR does / why we need it:

fix aggregator metric

Which issue(s) this PR fixes:

Special notes for your reviewer:

@luomingmeng luomingmeng marked this pull request as ready for review October 18, 2023 10:59
@codecov
Copy link

codecov bot commented Oct 18, 2023

Codecov Report

Attention: 14 lines in your changes are missing coverage. Please review.

Comparison is base (5652340) 53.17% compared to head (aef9950) 53.30%.
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #317      +/-   ##
==========================================
+ Coverage   53.17%   53.30%   +0.13%     
==========================================
  Files         406      408       +2     
  Lines       43980    44071      +91     
==========================================
+ Hits        23386    23494     +108     
+ Misses      18006    17986      -20     
- Partials     2588     2591       +3     
Flag Coverage Δ
unittest 53.30% <80.82%> (+0.13%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
pkg/custom-metric/store/data/cache.go 94.54% <100.00%> (+13.44%) ⬆️
pkg/custom-metric/store/data/internal.go 86.60% <100.00%> (+7.47%) ⬆️
pkg/custom-metric/store/local/local_store.go 69.08% <100.00%> (ø)
pkg/custom-metric/store/remote/remote_store.go 77.15% <100.00%> (ø)
pkg/custom-metric/store/data/types/aggragated.go 73.77% <89.65%> (+26.04%) ⬆️
pkg/custom-metric/store/data/types/util.go 44.00% <38.88%> (+0.25%) ⬆️

... and 18 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

waynepeking348
waynepeking348 previously approved these changes Oct 18, 2023
@waynepeking348 waynepeking348 added bug Something isn't working workflow/merge-ready merge-ready: code is ready and can be merged workflow/need-review review: test succeeded, need to review labels Oct 18, 2023
@waynepeking348 waynepeking348 merged commit 2c1ea48 into kubewharf:main Oct 18, 2023
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working workflow/merge-ready merge-ready: code is ready and can be merged workflow/need-review review: test succeeded, need to review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants