Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature(kcmas): scrape with basic auth #318

Merged
merged 1 commit into from
Oct 19, 2023

Conversation

zzzzhhb
Copy link
Collaborator

@zzzzhhb zzzzhhb commented Oct 18, 2023

What type of PR is this?

Enhancements

What this PR does / why we need it:

metric collector scrape with basic auth

Which issue(s) this PR fixes:

Special notes for your reviewer:

@zzzzhhb zzzzhhb self-assigned this Oct 18, 2023
@zzzzhhb zzzzhhb added enhancement New feature or request workflow/merge-hold merge-hold: code is ready but still has dependency workflow/need-review review: test succeeded, need to review labels Oct 18, 2023
waynepeking348
waynepeking348 previously approved these changes Oct 18, 2023
@zzzzhhb zzzzhhb force-pushed the metric_collector_basic_auth branch from 2448fb9 to d3d2ee3 Compare October 18, 2023 12:31
@zzzzhhb zzzzhhb added workflow/merge-ready merge-ready: code is ready and can be merged and removed workflow/merge-hold merge-hold: code is ready but still has dependency labels Oct 19, 2023
@codecov
Copy link

codecov bot commented Oct 19, 2023

Codecov Report

Attention: 17 lines in your changes are missing coverage. Please review.

Comparison is base (5652340) 53.17% compared to head (d3d2ee3) 53.23%.
Report is 7 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #318      +/-   ##
==========================================
+ Coverage   53.17%   53.23%   +0.06%     
==========================================
  Files         406      408       +2     
  Lines       43980    44110     +130     
==========================================
+ Hits        23386    23484      +98     
- Misses      18006    18038      +32     
  Partials     2588     2588              
Flag Coverage Δ
unittest 53.23% <52.77%> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
cmd/base/context.go 61.70% <100.00%> (ø)
pkg/custom-metric/collector/prometheus/scrape.go 72.89% <100.00%> (+0.12%) ⬆️
...metric/collector/prometheus/collector_promethes.go 27.27% <48.48%> (+2.65%) ⬆️

... and 25 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@waynepeking348 waynepeking348 merged commit 4694a8b into kubewharf:main Oct 19, 2023
10 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request workflow/merge-ready merge-ready: code is ready and can be merged workflow/need-review review: test succeeded, need to review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants