Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix window seconds #319

Merged

Conversation

luomingmeng
Copy link
Collaborator

What type of PR is this?

Bug fixes

What this PR does / why we need it:

add store metric length metrics and fix aggregator window

Which issue(s) this PR fixes:

Special notes for your reviewer:

@luomingmeng luomingmeng added bug Something isn't working workflow/need-review review: test succeeded, need to review labels Oct 18, 2023
@luomingmeng luomingmeng self-assigned this Oct 18, 2023
@luomingmeng luomingmeng marked this pull request as ready for review October 18, 2023 14:44
@luomingmeng luomingmeng added the workflow/merge-ready merge-ready: code is ready and can be merged label Oct 18, 2023
@luomingmeng luomingmeng force-pushed the dev/fix-kcmas-metric-count branch 2 times, most recently from 87759e7 to 17d526d Compare October 18, 2023 14:52
waynepeking348
waynepeking348 previously approved these changes Oct 18, 2023
@waynepeking348 waynepeking348 merged commit 3a15b27 into kubewharf:main Oct 19, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working workflow/merge-ready merge-ready: code is ready and can be merged workflow/need-review review: test succeeded, need to review
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

3 participants