Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

check coreCount within AggregateCoreMetric #320

Merged

Conversation

justadogistaken
Copy link
Contributor

What type of PR is this?

What this PR does / why we need it:

Which issue(s) this PR fixes:

Special notes for your reviewer:

@codecov
Copy link

codecov bot commented Oct 19, 2023

Codecov Report

Attention: 23 lines in your changes are missing coverage. Please review.

Comparison is base (5652340) 53.17% compared to head (88533bb) 53.18%.
Report is 8 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #320      +/-   ##
==========================================
+ Coverage   53.17%   53.18%   +0.01%     
==========================================
  Files         406      419      +13     
  Lines       43980    46297    +2317     
==========================================
+ Hits        23386    24625    +1239     
- Misses      18006    18884     +878     
- Partials     2588     2788     +200     
Flag Coverage Δ
unittest 53.18% <73.25%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
pkg/agent/evictionmanager/podkiller/killer.go 64.40% <100.00%> (+0.20%) ⬆️
pkg/util/metric/store_util.go 88.88% <100.00%> (+0.31%) ⬆️
...advisor/qosaware/resource/memory/memory_advisor.go 62.06% <66.66%> (+0.53%) ⬆️
...advisor/qosaware/resource/memory/plugins/common.go 80.00% <80.00%> (ø)
...r/qosaware/resource/memory/plugins/cache_reaper.go 63.63% <63.63%> (ø)
...advisor/plugin/qosaware/resource/memory/advisor.go 80.31% <33.33%> (-1.37%) ⬇️
...in/qosaware/resource/memory/plugin/cache_reaper.go 84.48% <76.00%> (-6.83%) ⬇️

... and 42 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@waynepeking348 waynepeking348 added bug Something isn't working workflow/merge-ready merge-ready: code is ready and can be merged labels Oct 19, 2023
@waynepeking348 waynepeking348 merged commit 6a1a153 into kubewharf:main Oct 19, 2023
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working workflow/merge-ready merge-ready: code is ready and can be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants