Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(advisor): support disable registered model result fetcher #321

Merged
merged 1 commit into from
Oct 19, 2023

Conversation

csfldf
Copy link
Collaborator

@csfldf csfldf commented Oct 19, 2023

feat(advisor): support disable registered model result fetcher

@csfldf csfldf added the workflow/need-review review: test succeeded, need to review label Oct 19, 2023
@csfldf csfldf self-assigned this Oct 19, 2023
@codecov
Copy link

codecov bot commented Oct 19, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (4694a8b) 53.24% compared to head (75f7b26) 53.25%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #321      +/-   ##
==========================================
+ Coverage   53.24%   53.25%   +0.01%     
==========================================
  Files         419      419              
  Lines       46295    46301       +6     
==========================================
+ Hits        24650    24658       +8     
+ Misses      18855    18851       -4     
- Partials     2790     2792       +2     
Flag Coverage Δ
unittest 53.25% <80.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...in/inference/modelresultfetcher/borwein/borwein.go 57.14% <100.00%> (-2.00%) ⬇️
pkg/agent/sysadvisor/plugin/inference/inference.go 77.77% <66.66%> (+0.85%) ⬆️

... and 17 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@csfldf csfldf force-pushed the dev/disable_model_fetcher branch from 4d6dbc5 to 75f7b26 Compare October 19, 2023 07:58
Copy link
Contributor

@justadogistaken justadogistaken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@waynepeking348 waynepeking348 added bug Something isn't working workflow/merge-ready merge-ready: code is ready and can be merged labels Oct 19, 2023
@waynepeking348 waynepeking348 merged commit 7dd32f6 into kubewharf:main Oct 19, 2023
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working workflow/merge-ready merge-ready: code is ready and can be merged workflow/need-review review: test succeeded, need to review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants