Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(http): non-strict authentication #323

Merged
merged 1 commit into from
Oct 20, 2023

Conversation

zzzzhhb
Copy link
Collaborator

@zzzzhhb zzzzhhb commented Oct 19, 2023

What type of PR is this?

Enhancements

What this PR does / why we need it:

support non-strict authentication

Which issue(s) this PR fixes:

Special notes for your reviewer:

@zzzzhhb zzzzhhb self-assigned this Oct 19, 2023
@zzzzhhb zzzzhhb added enhancement New feature or request workflow/need-review review: test succeeded, need to review workflow/merge-hold merge-hold: code is ready but still has dependency labels Oct 19, 2023
@codecov
Copy link

codecov bot commented Oct 19, 2023

Codecov Report

Attention: 28 lines in your changes are missing coverage. Please review.

Comparison is base (7dd32f6) 53.15% compared to head (8b99382) 53.13%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #323      +/-   ##
==========================================
- Coverage   53.15%   53.13%   -0.03%     
==========================================
  Files         419      419              
  Lines       46301    46332      +31     
==========================================
+ Hits        24611    24618       +7     
- Misses      18907    18929      +22     
- Partials     2783     2785       +2     
Flag Coverage Δ
unittest 53.13% <53.33%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
cmd/base/context.go 63.26% <100.00%> (+1.56%) ⬆️
cmd/base/options/generic.go 50.84% <100.00%> (+2.40%) ⬆️
cmd/katalyst-agent/app/agent/eviction.go 0.00% <ø> (ø)
cmd/base/options/auth.go 64.70% <66.66%> (-6.73%) ⬇️
pkg/util/process/http.go 64.82% <35.00%> (-7.80%) ⬇️

... and 15 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zzzzhhb zzzzhhb force-pushed the http_non_strict_authenticate branch 3 times, most recently from 0ce6adc to 2bb13c3 Compare October 20, 2023 06:30
@zzzzhhb zzzzhhb force-pushed the http_non_strict_authenticate branch from 2bb13c3 to 8b99382 Compare October 20, 2023 07:00
@zzzzhhb zzzzhhb added workflow/merge-ready merge-ready: code is ready and can be merged and removed workflow/merge-hold merge-hold: code is ready but still has dependency labels Oct 20, 2023
@waynepeking348 waynepeking348 merged commit bddd425 into kubewharf:main Oct 20, 2023
9 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request workflow/merge-ready merge-ready: code is ready and can be merged workflow/need-review review: test succeeded, need to review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants