Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add standard framework for service discovery #325

Conversation

waynepeking348
Copy link
Collaborator

What type of PR is this?

enhancements

What this PR does / why we need it:

add standard framework to support multiple service discovery implementations

@waynepeking348 waynepeking348 added enhancement New feature or request workflow/merge-hold merge-hold: code is ready but still has dependency labels Oct 23, 2023
@waynepeking348 waynepeking348 self-assigned this Oct 23, 2023
@waynepeking348 waynepeking348 force-pushed the add-framework-to-regsiter-service-discovery branch 5 times, most recently from a0b6437 to f4336a3 Compare October 25, 2023 03:36
@waynepeking348 waynepeking348 added workflow/need-review review: test succeeded, need to review and removed workflow/merge-hold merge-hold: code is ready but still has dependency labels Oct 25, 2023
@waynepeking348 waynepeking348 force-pushed the add-framework-to-regsiter-service-discovery branch 2 times, most recently from 3396b18 to b2cd2e6 Compare October 25, 2023 09:23
@codecov
Copy link

codecov bot commented Oct 25, 2023

Codecov Report

Attention: 409 lines in your changes are missing coverage. Please review.

Comparison is base (8a3529a) 53.18% compared to head (4a02a48) 53.45%.
Report is 8 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #325      +/-   ##
==========================================
+ Coverage   53.18%   53.45%   +0.26%     
==========================================
  Files         419      431      +12     
  Lines       46302    47265     +963     
==========================================
+ Hits        24627    25266     +639     
- Misses      18891    19137     +246     
- Partials     2784     2862      +78     
Flag Coverage Δ
unittest 53.45% <62.47%> (+0.26%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
cmd/base/context.go 63.26% <100.00%> (+1.56%) ⬆️
cmd/base/context_fake.go 71.72% <100.00%> (+4.36%) ⬆️
cmd/base/options/generic.go 50.84% <100.00%> (+2.40%) ⬆️
cmd/katalyst-agent/app/agent/eviction.go 0.00% <ø> (ø)
...aware/resource/helper/modelctrl/borwein/borwein.go 75.00% <100.00%> (+1.17%) ⬆️
pkg/agent/sysadvisor/types/helper.go 70.31% <100.00%> (ø)
...metric/collector/prometheus/collector_promethes.go 27.27% <ø> (ø)
pkg/custom-metric/collector/prometheus/scrape.go 73.99% <100.00%> (+1.09%) ⬆️
cmd/katalyst-controller/app/options/controller.go 59.37% <87.50%> (+0.75%) ⬆️
cmd/base/options/auth.go 64.70% <66.66%> (-6.73%) ⬇️
... and 19 more

... and 19 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@waynepeking348 waynepeking348 force-pushed the add-framework-to-regsiter-service-discovery branch from b2cd2e6 to d0aedce Compare October 25, 2023 15:46
@waynepeking348 waynepeking348 added the workflow/merge-ready merge-ready: code is ready and can be merged label Oct 25, 2023
@waynepeking348 waynepeking348 force-pushed the add-framework-to-regsiter-service-discovery branch from d0aedce to 4a02a48 Compare October 26, 2023 06:38
@waynepeking348 waynepeking348 merged commit f8d8ec2 into kubewharf:main Oct 26, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request workflow/merge-ready merge-ready: code is ready and can be merged workflow/need-review review: test succeeded, need to review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants