Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kcams add collector scrape out of date metrics #328

Conversation

luomingmeng
Copy link
Collaborator

What type of PR is this?

Enhancements

What this PR does / why we need it:

kcams add collector scrape out of date metrics

Which issue(s) this PR fixes:

Special notes for your reviewer:

@luomingmeng luomingmeng marked this pull request as ready for review October 24, 2023 05:25
@luomingmeng luomingmeng self-assigned this Oct 24, 2023
@luomingmeng luomingmeng added chore workflow/need-review review: test succeeded, need to review labels Oct 24, 2023
@codecov
Copy link

codecov bot commented Oct 24, 2023

Codecov Report

Attention: 28 lines in your changes are missing coverage. Please review.

Comparison is base (8a3529a) 53.18% compared to head (7d02a0b) 53.11%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #328      +/-   ##
==========================================
- Coverage   53.18%   53.11%   -0.07%     
==========================================
  Files         419      419              
  Lines       46302    46342      +40     
==========================================
- Hits        24627    24616      -11     
- Misses      18891    18944      +53     
+ Partials     2784     2782       -2     
Flag Coverage Δ
unittest 53.11% <59.42%> (-0.07%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
cmd/base/context.go 63.26% <100.00%> (+1.56%) ⬆️
cmd/base/options/generic.go 50.84% <100.00%> (+2.40%) ⬆️
cmd/katalyst-agent/app/agent/eviction.go 0.00% <ø> (ø)
...metric/collector/prometheus/collector_promethes.go 27.27% <ø> (ø)
pkg/custom-metric/collector/prometheus/scrape.go 73.99% <100.00%> (+1.09%) ⬆️
cmd/base/options/auth.go 64.70% <66.66%> (-6.73%) ⬇️
pkg/util/process/http.go 64.82% <35.00%> (-7.80%) ⬇️

... and 17 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@luomingmeng luomingmeng added the workflow/merge-ready merge-ready: code is ready and can be merged label Oct 24, 2023
@waynepeking348 waynepeking348 merged commit 78c296c into kubewharf:main Oct 24, 2023
11 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore workflow/merge-ready merge-ready: code is ready and can be merged workflow/need-review review: test succeeded, need to review
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

3 participants