Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf(kcmas): performance optimization #329

Merged
merged 1 commit into from
Oct 30, 2023

Conversation

zzzzhhb
Copy link
Collaborator

@zzzzhhb zzzzhhb commented Oct 24, 2023

What type of PR is this?

Enhancements

What this PR does / why we need it:

  1. fix kcmas data latency monitor
  2. some performance optimization

Which issue(s) this PR fixes:

Special notes for your reviewer:

@codecov
Copy link

codecov bot commented Oct 24, 2023

Codecov Report

Attention: 17 lines in your changes are missing coverage. Please review.

Comparison is base (0652975) 53.48% compared to head (5bb3510) 53.53%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #329      +/-   ##
==========================================
+ Coverage   53.48%   53.53%   +0.05%     
==========================================
  Files         431      431              
  Lines       47265    47320      +55     
==========================================
+ Hits        25278    25334      +56     
- Misses      19125    19127       +2     
+ Partials     2862     2859       -3     
Flag Coverage Δ
unittest 53.53% <79.26%> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...t/evictionmanager/plugin/memory/system_pressure.go 73.36% <100.00%> (+0.40%) ⬆️
pkg/custom-metric/provider/provider.go 83.55% <100.00%> (+1.00%) ⬆️
pkg/custom-metric/store/data/cache.go 94.94% <100.00%> (+0.23%) ⬆️
pkg/custom-metric/store/data/internal.go 86.60% <100.00%> (ø)
pkg/custom-metric/store/data/types/series.go 88.00% <100.00%> (+3.00%) ⬆️
pkg/metrics/tag_wrapper_metrics.go 82.50% <100.00%> (+1.94%) ⬆️
pkg/util/general/deepcopy.go 50.00% <50.00%> (ø)
...amic/adminqos/eviction/memory_pressure_eviction.go 50.81% <37.50%> (-2.02%) ⬇️
pkg/custom-metric/store/data/types/aggragated.go 64.28% <0.00%> (-9.49%) ⬇️

... and 15 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zzzzhhb zzzzhhb force-pushed the data_latency_monitor branch from 09fb062 to 5bb3510 Compare October 30, 2023 07:13
@zzzzhhb zzzzhhb added workflow/merge-ready merge-ready: code is ready and can be merged enhancement New feature or request workflow/need-review review: test succeeded, need to review labels Oct 30, 2023
@zzzzhhb zzzzhhb changed the title [WIP]perf(kcmas): performance optimization perf(kcmas): performance optimization Oct 30, 2023
@waynepeking348 waynepeking348 merged commit bf2d03c into kubewharf:main Oct 30, 2023
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request workflow/merge-ready merge-ready: code is ready and can be merged workflow/need-review review: test succeeded, need to review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants