Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add pod_cpu_cpi in custom metric #332

Merged
merged 1 commit into from
Oct 26, 2023

Conversation

justadogistaken
Copy link
Contributor

@justadogistaken justadogistaken commented Oct 26, 2023

@justadogistaken justadogistaken self-assigned this Oct 26, 2023
@justadogistaken justadogistaken added the workflow/merge-ready merge-ready: code is ready and can be merged label Oct 26, 2023
@justadogistaken
Copy link
Contributor Author

go.mod will be updated when pr in api merged.

@codecov
Copy link

codecov bot commented Oct 26, 2023

Codecov Report

Attention: 28 lines in your changes are missing coverage. Please review.

Comparison is base (8a3529a) 53.18% compared to head (9d9f27d) 53.27%.
Report is 8 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #332      +/-   ##
==========================================
+ Coverage   53.18%   53.27%   +0.08%     
==========================================
  Files         419      428       +9     
  Lines       46302    47176     +874     
==========================================
+ Hits        24627    25131     +504     
- Misses      18891    19213     +322     
- Partials     2784     2832      +48     
Flag Coverage Δ
unittest 53.27% <53.33%> (+0.08%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
cmd/base/context.go 63.26% <100.00%> (+1.56%) ⬆️
cmd/base/options/generic.go 50.84% <100.00%> (+2.40%) ⬆️
cmd/katalyst-agent/app/agent/eviction.go 0.00% <ø> (ø)
...sysadvisor/plugin/metric-emitter/syncer/pod/pod.go 66.44% <ø> (ø)
cmd/base/options/auth.go 64.70% <66.66%> (-6.73%) ⬇️
pkg/util/process/http.go 64.82% <35.00%> (-7.80%) ⬇️

... and 37 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@waynepeking348 waynepeking348 merged commit f9bfffe into kubewharf:main Oct 26, 2023
8 of 9 checks passed
@justadogistaken justadogistaken deleted the add_cpi_in_kcmas branch October 26, 2023 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
workflow/merge-ready merge-ready: code is ready and can be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants