Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP]feat(kcmas):mock collector #335

Merged
merged 1 commit into from
Nov 2, 2023

Conversation

zzzzhhb
Copy link
Collaborator

@zzzzhhb zzzzhhb commented Oct 31, 2023

What type of PR is this?

Enhancements

What this PR does / why we need it:

kcmas supports generating mock data for pressure test.

Which issue(s) this PR fixes:

Special notes for your reviewer:

@codecov
Copy link

codecov bot commented Oct 31, 2023

Codecov Report

Attention: 173 lines in your changes are missing coverage. Please review.

Comparison is base (1ccf532) 53.51% compared to head (066145c) 53.37%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #335      +/-   ##
==========================================
- Coverage   53.51%   53.37%   -0.14%     
==========================================
  Files         431      434       +3     
  Lines       47356    47551     +195     
==========================================
+ Hits        25341    25382      +41     
- Misses      19167    19320     +153     
- Partials     2848     2849       +1     
Flag Coverage Δ
unittest 53.37% <11.28%> (-0.14%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
pkg/custom-metric/mock/utils.go 100.00% <100.00%> (ø)
pkg/custom-metric/mock/mock_store.go 0.00% <0.00%> (ø)
pkg/custom-metric/mock/mock_collector.go 0.00% <0.00%> (ø)

... and 16 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zzzzhhb zzzzhhb self-assigned this Oct 31, 2023
@zzzzhhb zzzzhhb added enhancement New feature or request workflow/need-review review: test succeeded, need to review workflow/merge-hold merge-hold: code is ready but still has dependency labels Oct 31, 2023
@zzzzhhb zzzzhhb added workflow/merge-ready merge-ready: code is ready and can be merged and removed workflow/merge-hold merge-hold: code is ready but still has dependency labels Nov 1, 2023
@waynepeking348 waynepeking348 merged commit 1882504 into kubewharf:main Nov 2, 2023
9 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request workflow/merge-ready merge-ready: code is ready and can be merged workflow/need-review review: test succeeded, need to review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants