Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(generic): add kube-aggregator client #337

Merged
merged 1 commit into from
Nov 1, 2023

Conversation

zzzzhhb
Copy link
Collaborator

@zzzzhhb zzzzhhb commented Nov 1, 2023

What type of PR is this?

Enhancements

What this PR does / why we need it:

add kube-aggregator client

Which issue(s) this PR fixes:

Special notes for your reviewer:

@zzzzhhb zzzzhhb self-assigned this Nov 1, 2023
@zzzzhhb zzzzhhb added enhancement New feature or request workflow/need-review review: test succeeded, need to review workflow/merge-ready merge-ready: code is ready and can be merged labels Nov 1, 2023
Copy link

codecov bot commented Nov 1, 2023

Codecov Report

Attention: 11 lines in your changes are missing coverage. Please review.

Comparison is base (1ccf532) 53.51% compared to head (49b4716) 53.30%.

❗ Current head 49b4716 differs from pull request most recent head 775e5b9. Consider uploading reports for the commit 775e5b9 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #337      +/-   ##
==========================================
- Coverage   53.51%   53.30%   -0.21%     
==========================================
  Files         431      431              
  Lines       47356    47368      +12     
==========================================
- Hits        25341    25250      -91     
- Misses      19167    19268     +101     
- Partials     2848     2850       +2     
Flag Coverage Δ
unittest 53.30% <63.33%> (-0.21%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
cmd/base/context.go 64.23% <100.00%> (+0.97%) ⬆️
cmd/base/context_fake.go 74.32% <100.00%> (+2.60%) ⬆️
pkg/client/genericclient.go 0.00% <0.00%> (ø)

... and 15 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

waynepeking348
waynepeking348 previously approved these changes Nov 1, 2023
@waynepeking348 waynepeking348 merged commit c207cd8 into kubewharf:main Nov 1, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request workflow/merge-ready merge-ready: code is ready and can be merged workflow/need-review review: test succeeded, need to review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants