Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(metaserver): add node cpu usage ratio metric #339

Merged
merged 1 commit into from
Nov 2, 2023

Conversation

cheney-lin
Copy link
Member

What type of PR is this?

Enhancements

What this PR does / why we need it:

Which issue(s) this PR fixes:

Special notes for your reviewer:

Signed-off-by: linzhecheng <linzhecheng@bytedance.com>
@cheney-lin cheney-lin self-assigned this Nov 2, 2023
@cheney-lin cheney-lin added enhancement New feature or request workflow/need-review review: test succeeded, need to review labels Nov 2, 2023
Copy link

codecov bot commented Nov 2, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (bf2d03c) 53.26% compared to head (bc45178) 53.36%.
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #339      +/-   ##
==========================================
+ Coverage   53.26%   53.36%   +0.10%     
==========================================
  Files         431      431              
  Lines       47320    47368      +48     
==========================================
+ Hits        25204    25280      +76     
+ Misses      19261    19238      -23     
+ Partials     2855     2850       -5     
Flag Coverage Δ
unittest 53.36% <100.00%> (+0.10%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
pkg/metaserver/agent/metric/malachite/fetcher.go 53.09% <100.00%> (+0.11%) ⬆️

... and 17 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cheney-lin cheney-lin requested a review from csfldf November 2, 2023 08:50
@cheney-lin cheney-lin added workflow/merge-ready merge-ready: code is ready and can be merged and removed workflow/need-review review: test succeeded, need to review labels Nov 2, 2023
@waynepeking348 waynepeking348 merged commit ff1a6d6 into kubewharf:main Nov 2, 2023
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request workflow/merge-ready merge-ready: code is ready and can be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants